From mboxrd@z Thu Jan  1 00:00:00 1970
From: Wolfgang Denk <wd@denx.de>
Date: Sat, 14 Jan 2012 00:13:10 +0100
Subject: [U-Boot] [PATCH] post/Makefile: Only build FP post tests if
	enabled via CONFIG_SYS_POST_FPU
In-Reply-To: <1326396641-20928-1-git-send-email-galak@kernel.crashing.org>
References: <1326396641-20928-1-git-send-email-galak@kernel.crashing.org>
Message-ID: <20120113231310.8EADD11CDEDB@gemini.denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Kumar Gala,

In message <1326396641-20928-1-git-send-email-galak@kernel.crashing.org> you wrote:
> Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
> ---
>  post/Makefile |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/post/Makefile b/post/Makefile
> index 200e2f1..55b7d21 100644
> --- a/post/Makefile
> +++ b/post/Makefile
> @@ -32,7 +32,7 @@ COBJS-$(CONFIG_POST_STD_LIST)	+= tests.o
>  SPLIB-$(CONFIG_HAS_POST) = drivers/libpostdrivers.o
>  SPLIB-$(CONFIG_HAS_POST) += $(shell if [ -d lib_$(ARCH) ]; then echo \
>  			    "lib_$(ARCH)/libpost$(ARCH).o"; fi)
> -SPLIB-$(CONFIG_HAS_POST) += $(shell if [ -d lib_$(ARCH)/fpu ]; then echo \
> +SPLIB-$(CONFIG_SYS_POST_FPU) += $(shell if [ -d lib_$(ARCH)/fpu ]; then echo \
>  			    "lib_$(ARCH)/fpu/libpost$(ARCH)fpu.o"; fi)
>  SPLIB-$(CONFIG_HAS_POST) += $(shell if [ -d cpu/$(CPU) ]; then echo \
>  			    "cpu/$(CPU)/libpost$(CPU).o"; fi)

Unfortunately I applied this patch without sufficient tesing.  It
breaks a number of boards:

Configuring for korat board...
post/libpost.o:(.data.rel.post_list+0xb0): undefined reference to `fpu_post_test'
make: *** [/work/wd/tmp-ppc/u-boot] Error 1
powerpc-linux-size: '/work/wd/tmp-ppc/u-boot': No such file
Configuring for korat_perm - Board: korat, Options: KORAT_PERMANENT
post/libpost.o:(.data.rel.post_list+0xb0): undefined reference to `fpu_post_test'
make: *** [/work/wd/tmp-ppc/u-boot] Error 1
powerpc-linux-size: '/work/wd/tmp-ppc/u-boot': No such file
Configuring for lwmon5 board...
post/libpost.o:(.data.rel.post_list+0xf0): undefined reference to `fpu_post_test'
make: *** [/work/wd/tmp-ppc/u-boot] Error 1
powerpc-linux-size: '/work/wd/tmp-ppc/u-boot': No such file
Configuring for sequoia - Board: sequoia, Options: SEQUOIA
post/libpost.o:(.data.rel.post_list+0x90): undefined reference to `fpu_post_test'
make: *** [/work/wd/tmp-ppc/u-boot] Error 1
powerpc-linux-size: '/work/wd/tmp-ppc/u-boot': No such file
Configuring for sequoia_nand - Board: sequoia, Options: SEQUOIA,NAND_U_BOOT,SYS_TEXT_BASE=0x01000000
post/libpost.o:(.data.rel.post_list+0x70): undefined reference to `fpu_post_test'
make: *** [/work/wd/tmp-ppc/u-boot] Error 1
powerpc-linux-size: '/work/wd/tmp-ppc/u-boot': No such file
Configuring for sequoia_ramboot - Board: sequoia, Options: SEQUOIA,SYS_RAMBOOT,SYS_TEXT_BASE=0x01000000,SYS_LDSCRIPT=board/amcc/sequoia/u-boot-ram.lds
post/libpost.o:(.data.rel.post_list+0x70): undefined reference to `fpu_post_test'
make: *** [/work/wd/tmp-ppc/u-boot] Error 1
powerpc-linux-size: '/work/wd/tmp-ppc/u-boot': No such file
Configuring for PMC440 board...
post/libpost.o:(.data.rel.post_list+0x90): undefined reference to `fpu_post_test'
make: *** [/work/wd/tmp-ppc/u-boot] Error 1
powerpc-linux-size: '/work/wd/tmp-ppc/u-boot': No such file


Please provide a fix.  Alternatively I can revert that patch.

Thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Life. Don't talk to me about life.      - Marvin the Paranoid Android