public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] configs: Remove CONFIG_NET_MULTI from board files
Date: Sat, 14 Jan 2012 19:53:21 -0500	[thread overview]
Message-ID: <201201141953.22850.vapier@gentoo.org> (raw)
In-Reply-To: <1326286051-14349-1-git-send-email-festevam@gmail.com>

On Wednesday 11 January 2012 07:47:31 Fabio Estevam wrote:
> CONFIG_NET_MULTI is not used anymore, so remove it from board files.

NAK: idea: good.  actual patch: buggy :(.

> --- a/include/configs/P1010RDB.h
> +++ b/include/configs/P1010RDB.h
> 
> -#if defined(CONFIG_TSEC_ENET)
> -#ifndef CONFIG_NET_MULTI
> -#define CONFIG_NET_MULTI
> -#endif
> -
>  #define CONFIG_MII			/* MII PHY management */
>  #define CONFIG_MII_DEFAULT_TSEC	1	/* Allow unregistered phys */
>  #define CONFIG_TSEC1	1

you sure this is correct ?  looks like you deleted 2 if statements but only 1 
endif.

> --- a/include/configs/p1_p2_rdb_pc.h
> +++ b/include/configs/p1_p2_rdb_pc.h
>
>  #define CONFIG_DOS_PARTITION
>  #endif /* CONFIG_PCI */
> 
> -#if defined(CONFIG_TSEC_ENET)
> -
> -#ifndef CONFIG_NET_MULTI
> -#define CONFIG_NET_MULTI
> -#endif
> -
>  #define CONFIG_MII		/* MII PHY management */
>  #define CONFIG_TSEC1
>  #define CONFIG_TSEC1_NAME	"eTSEC1"

same issue here
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120114/3d46b22f/attachment.pgp>

  parent reply	other threads:[~2012-01-15  0:53 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-11 12:47 [U-Boot] [PATCH] configs: Remove CONFIG_NET_MULTI from board files Fabio Estevam
2012-01-11 12:49 ` Marek Vasut
2012-01-11 13:38 ` Heiko Schocher
2012-01-11 14:06 ` Kumar Gala
2012-01-11 14:06 ` Stefano Babic
2012-01-11 16:19 ` Tom Rini
2012-01-14 10:08 ` Stefano Babic
2012-01-15  1:12   ` Mike Frysinger
2012-01-15 14:13     ` Stefano Babic
2012-01-15  0:53 ` Mike Frysinger [this message]
2012-01-15 15:03 ` [U-Boot] [PATCH v2] " Fabio Estevam
2012-01-15 15:06   ` Tom Rini
2012-01-15 18:38   ` Mike Frysinger
2012-01-17 10:22   ` Stefano Babic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201201141953.22850.vapier@gentoo.org \
    --to=vapier@gentoo.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox