From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/3] common: add possibility for readline_into_buffer timeout
Date: Sun, 15 Jan 2012 12:35:01 -0500 [thread overview]
Message-ID: <201201151235.01689.vapier@gentoo.org> (raw)
In-Reply-To: <1326614022-24014-2-git-send-email-hs@denx.de>
On Sunday 15 January 2012 02:53:40 Heiko Schocher wrote:
> --- a/common/main.c
> +++ b/common/main.c
>
> + if ((first) && (timeout)) {
those inner parens make no sense
> + ulong start = get_timer(0);
> + ulong delay = timeout * CONFIG_SYS_HZ;
what do you want the timeout to be in ? milliseconds ? then make that part
of the API (add comments to the relevant funcs), and drop the CONFIG_SYS_HZ
usage.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120115/347da045/attachment.pgp>
next prev parent reply other threads:[~2012-01-15 17:35 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-15 7:53 [U-Boot] [PATCH 0/3] common, menu: enhancements Heiko Schocher
2012-01-15 7:53 ` [U-Boot] [PATCH 1/3] common: add possibility for readline_into_buffer timeout Heiko Schocher
2012-01-15 17:35 ` Mike Frysinger [this message]
2012-01-16 6:43 ` Heiko Schocher
2012-01-17 7:13 ` [U-Boot] [PATCH 1/3 v2] " Heiko Schocher
2012-01-17 19:14 ` Mike Frysinger
2012-02-17 21:33 ` Stephan Linz
2012-02-17 23:18 ` Mike Frysinger
2012-01-15 7:53 ` [U-Boot] [PATCH 2/3] common, menu: add statusline support Heiko Schocher
2012-01-15 17:36 ` Mike Frysinger
2012-01-16 6:54 ` Heiko Schocher
2012-01-17 7:13 ` [U-Boot] [PATCH 2/3 v2] " Heiko Schocher
2012-01-17 19:14 ` Mike Frysinger
2012-01-15 7:53 ` [U-Boot] [PATCH 3/3] common, menu: show menu on startup if CONFIG_MENU_SHOW is defined Heiko Schocher
2012-01-15 17:38 ` Mike Frysinger
2012-01-16 6:55 ` Heiko Schocher
2012-01-17 7:13 ` [U-Boot] [PATCH 3/3 v2] " Heiko Schocher
2012-01-17 12:55 ` Jason Hobbs
2012-01-18 6:05 ` [U-Boot] [PATCH 3/3 v3] " Heiko Schocher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201201151235.01689.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox