From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Denk Date: Mon, 16 Jan 2012 09:19:34 +0100 Subject: [U-Boot] [PATCH 1/5] net: ll_temac: Add LL TEMAC driver to u-boot In-Reply-To: <1326656467.18981.225.camel@keto> References: <1326642119.18981.190.camel@keto> <201201151228.42149.vapier@gentoo.org> <1326652166.18981.213.camel@keto> <201201151347.24190.vapier@gentoo.org> <1326656467.18981.225.camel@keto> Message-ID: <20120116081934.7BDF117133E2@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Stephan Linz, In message <1326656467.18981.225.camel@keto> you wrote: > > OK, I'll try to change the buffer handling as soon as possible in one of > the next optimization stages of this driver. Looks interesting and > important to me ... ... > The alignment is essential for the LL TEMAC driver, especially the 32 > byte alignment. I look to continue to optimize this part after the patch > has been added. No, please do it now. I will not pull the current patch. > > or do it now and re-submit a v2 ... > > I have already done. Patch is coming up ... :-) No, you misunderstant. You submitted an incremental, separate patch. But we don't want to add code that is known to have problems / shortcomings now and fix / improve it 5 minutes later. We let the patch ripe and add it only when we consider it ready. So please do not defer weorkign on the review comments. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de "Look! There! Evil!.. pure and simple, total evil from the Eighth Dimension!" - Buckaroo Banzai