public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] net: move bootfile/ipaddr init into eth_initialize
Date: Mon, 16 Jan 2012 14:59:38 -0500	[thread overview]
Message-ID: <201201161459.43182.vapier@gentoo.org> (raw)
In-Reply-To: <20120116111826.524D617133E1@gemini.denx.de>

On Monday 16 January 2012 06:18:26 Wolfgang Denk wrote:
> Mike Frysinger wrote:
> > > The code which you remove here does NOT depend on CONFIG_CMD_NET;
> > > note that this is intentional.
> > 
> > i noticed that, however, i'm not sure it matters.  i can't find any place
> > in u- boot that actually reads this variable.
> 
> For example, the "bdinfo" command prints it; see common/cmd_bdinfo.c

which i documented as the *only* place where the member gets read:
	common/cmd_bdinfo.c: the value of bi_ip_addr gets displayed

and that would be absolutely trivial to replace with getenv("ipaddr")
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120116/dd8d8390/attachment.pgp>

  reply	other threads:[~2012-01-16 19:59 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-15 23:32 [U-Boot] [PATCH] net: move bootfile/ipaddr init into eth_initialize Mike Frysinger
2012-01-16  2:28 ` Thomas Chou
2012-01-16  8:03 ` Wolfgang Denk
2012-01-16 10:05   ` Mike Frysinger
2012-01-16 11:18     ` Wolfgang Denk
2012-01-16 19:59       ` Mike Frysinger [this message]
2012-01-17  2:10 ` [U-Boot] [PATCH 1/2] net: punt bd->bi_ip_addr Mike Frysinger
2012-01-17  2:10   ` [U-Boot] [PATCH 2/2] net: move bootfile init into eth_initialize Mike Frysinger
2012-04-04 14:22     ` Joe Hershberger
2012-04-04 14:21   ` [U-Boot] [PATCH 1/2] net: punt bd->bi_ip_addr Joe Hershberger
2012-04-05  4:53 ` [U-Boot] [PATCH 1/2 v2] " Mike Frysinger
2012-04-05  4:53   ` [U-Boot] [PATCH 2/2 v2] net: move bootfile init into eth_initialize Mike Frysinger
2012-05-15 23:01     ` Joe Hershberger
2012-05-15 23:00   ` [U-Boot] [PATCH 1/2 v2] net: punt bd->bi_ip_addr Joe Hershberger
2012-05-21  7:13   ` [U-Boot] [PATCH] Fix cmd_nvedit.c: warning: unused variable 'bd' Wolfgang Denk
2012-05-21 20:49     ` Joe Hershberger
2012-05-21 21:55       ` Wolfgang Denk
2012-05-21 21:56         ` Joe Hershberger
2012-05-21 22:01           ` Wolfgang Denk
2012-05-21 22:02             ` Joe Hershberger
2012-08-27 19:29   ` [U-Boot] [PATCH 1/2 v2] net: punt bd->bi_ip_addr Anatolij Gustschin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201201161459.43182.vapier@gentoo.org \
    --to=vapier@gentoo.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox