From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] common, menu: do not trigger timeout again, if a line is read
Date: Tue, 17 Jan 2012 14:16:33 -0500 [thread overview]
Message-ID: <201201171416.33834.vapier@gentoo.org> (raw)
In-Reply-To: <1326788669-23493-1-git-send-email-hs@denx.de>
On Tuesday 17 January 2012 03:24:29 Heiko Schocher wrote:
> --- a/common/menu.c
> +++ b/common/menu.c
> choice_item = menu_item_by_key(m, cbuf);
>
> - if (!choice_item)
> + if (!choice_item) {
> printf("%s not found\n", cbuf);
> + m->timeout = 0;
> + }
> } else {
> puts("^C\n");
> return -EINTR;
the summary says "do not timeout again if a line is read", but this C code
seems like "do not timeout again if an item was selected but not found". but
maybe i'm reading the menu code incorrectly ?
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120117/425e91f8/attachment.pgp>
next prev parent reply other threads:[~2012-01-17 19:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-17 8:24 [U-Boot] [PATCH] common, menu: do not trigger timeout again, if a line is read Heiko Schocher
2012-01-17 12:47 ` Jason Hobbs
2012-01-17 19:16 ` Mike Frysinger [this message]
2012-01-18 6:13 ` Heiko Schocher
2012-01-18 6:18 ` [U-Boot] [PATCH v2] common, menu: do not timeout again if an item was selected but not found Heiko Schocher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201201171416.33834.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox