From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/3] i2c: add i2c_core and prepare for new multibus support
Date: Tue, 17 Jan 2012 14:23:04 -0500 [thread overview]
Message-ID: <201201171423.05666.vapier@gentoo.org> (raw)
In-Reply-To: <1326784345-19953-2-git-send-email-sjg@chromium.org>
On Tuesday 17 January 2012 02:12:23 Simon Glass wrote:
> +#if defined(CONFIG_SYS_I2C)
> + void *cur_adap; /* current used i2c adapter */
> +#endif
let's have "i2c" in the variable name somewhere. "curr_i2c" ?
> --- /dev/null
> +++ b/drivers/i2c/i2c_core.c
>
> +#ifdef CONFIG_TEGRA2_I2C
> +extern struct i2c_adapter tegra_i2c_adap[];
> +#endif
i feel like if your initial run includes i2c bus specific defines, the end
result is a failure
> +struct i2c_adapter *i2c_adap[CONFIG_SYS_NUM_I2C_ADAPTERS] =
> + CONFIG_SYS_I2C_ADAPTERS;
> +#ifndef CONFIG_SYS_I2C_DIRECT_BUS
> +struct i2c_bus i2c_bus[CONFIG_SYS_NUM_I2C_BUSSES] = CONFIG_SYS_I2C_BUSSES;
> +#endif
the nand layer is moving away from this style ...
> + * mux_id is the multiplexer chip type from defined in i2c.h. So far only
> + * NXP (Philips) PCA954x multiplexers are supported. Switches are NOT
> + * supported (anybody uses them?)
does part-specific stuff belong in the core ? seems like it should be in a
part-specific driver ...
> +int i2c_probe(u_int8_t chip)
use uintx_t types. the u_intx_t types are deprecated.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120117/35443437/attachment.pgp>
next prev parent reply other threads:[~2012-01-17 19:23 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-17 7:12 [U-Boot] [PATCH 0/3] Bring in new I2C framework Simon Glass
2012-01-17 7:12 ` [U-Boot] [PATCH 1/3] i2c: add i2c_core and prepare for new multibus support Simon Glass
2012-01-17 19:23 ` Mike Frysinger [this message]
2012-01-18 20:11 ` Tabi Timur-B04825
2012-01-18 20:41 ` Mike Frysinger
2012-01-18 20:43 ` Timur Tabi
2012-01-18 21:37 ` Simon Glass
2012-01-18 21:39 ` Timur Tabi
2012-01-18 22:21 ` Simon Glass
2012-01-18 22:24 ` Timur Tabi
2012-01-19 5:36 ` Wolfgang Denk
2012-01-19 6:35 ` Heiko Schocher
2012-01-19 6:53 ` Simon Glass
2012-01-19 7:53 ` Heiko Schocher
2012-01-19 18:07 ` Simon Glass
2012-01-19 11:20 ` Wolfgang Denk
2012-01-19 18:10 ` Simon Glass
2012-01-19 18:47 ` Timur Tabi
2012-01-20 6:50 ` Heiko Schocher
2012-01-17 7:12 ` [U-Boot] [PATCH 2/3] i2c: common changes for multibus/multiadapter support Simon Glass
2012-01-17 7:12 ` [U-Boot] [PATCH 3/3] WIP: tegra: i2c: Enable new I2C framework Simon Glass
2012-01-17 8:51 ` Heiko Schocher
2012-01-17 8:30 ` [U-Boot] [PATCH 0/3] Bring in " Heiko Schocher
-- strict thread matches above, loose matches on Subject: below --
2012-10-22 17:40 Heiko Schocher
2012-10-22 17:40 ` [U-Boot] [PATCH 1/3] i2c: add i2c_core and prepare for new multibus support Heiko Schocher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201201171423.05666.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox