From: Marek Vasut <marek.vasut@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/6] mx6q: Add support for ECSPI through mxc_spi driver
Date: Wed, 18 Jan 2012 02:27:17 +0100 [thread overview]
Message-ID: <201201180227.17414.marek.vasut@gmail.com> (raw)
In-Reply-To: <4F1613FF.8060700@boundarydevices.com>
> On 01/17/2012 04:19 PM, Marek Vasut wrote:
> >> Signed-off-by: Eric Nelson<eric.nelson@boundarydevices.com>
> >> ---
> >>
> >> arch/arm/include/asm/arch-mx6/imx-regs.h | 44
> >>
> >> ++++++++++++++++++++++++++++++ 1 files changed, 44 insertions(+), 0
> >> deletions(-)
> >>
> >> diff --git a/arch/arm/include/asm/arch-mx6/imx-regs.h
> >> b/arch/arm/include/asm/arch-mx6/imx-regs.h index 7650cb9..00040c4 100644
> >> --- a/arch/arm/include/asm/arch-mx6/imx-regs.h
> >> +++ b/arch/arm/include/asm/arch-mx6/imx-regs.h
> >> @@ -190,6 +190,50 @@ struct src {
> >>
> >> u32 gpr10;
> >>
> >> };
> >>
> >> +/* ECSPI registers */
> >> +struct cspi_regs {
> >> + u32 rxdata;
> >> + u32 txdata;
> >> + u32 ctrl;
> >> + u32 cfg;
> >> + u32 intr;
> >> + u32 dma;
> >> + u32 stat;
> >> + u32 period;
> >> +};
> >
> > Sigh ... it's no fun I can have only one remark :-)
> >
> > Is this part common for all imx-es ?
>
> All i.MX6's
>
> This is a cut & paste from MX51.
>
> I was tempted to introduce an 'mxc_ecspi.h' to merge the declaration
> for i.MX5x and i.MX6 which share the ECSPI peripheral and 'mxc_cspi.h'
> for i.MX31 and i.MX35 that share the CSPI peripheral.
But you don't even need this outside of the spi driver so just put it into the
spi driver and be done with it. That'll solve your duplication issue.
M
next prev parent reply other threads:[~2012-01-18 1:27 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-17 22:09 [U-Boot] mxc_spi refactoring (for mx6q) Eric Nelson
2012-01-17 22:09 ` [U-Boot] [PATCH 1/6] mxc_spi: move machine specifics into CPU headers Eric Nelson
2012-01-17 22:09 ` [U-Boot] [PATCH 2/6] mx6q: Add support for ECSPI through mxc_spi driver Eric Nelson
2012-01-17 23:19 ` Marek Vasut
2012-01-18 0:36 ` Eric Nelson
2012-01-18 1:27 ` Marek Vasut [this message]
2012-01-18 1:44 ` Eric Nelson
2012-01-18 1:47 ` Marek Vasut
2012-01-18 2:02 ` Eric Nelson
2012-01-18 8:39 ` Stefano Babic
2012-01-18 16:08 ` Marek Vasut
2012-01-18 16:41 ` Stefano Babic
2012-01-18 20:05 ` Eric Nelson
2012-01-19 10:33 ` Stefano Babic
2012-01-17 22:09 ` [U-Boot] [PATCH 3/6] mx6q: mx6qsabrelite: Add ECSPI support to the Sabrelite platform Eric Nelson
2012-01-17 22:09 ` [U-Boot] [PATCH 4/6] sf command: allow default chip select through CONFIG_SPI_FLASH_CS Eric Nelson
2012-01-17 22:09 ` [U-Boot] [PATCH 5/6] mx6q: mx6qsabrelite: Provide default chip-select for serial flash Eric Nelson
2012-01-17 22:09 ` [U-Boot] [PATCH 6/6] mx6q: mx6qsabrelite: Provide defaults for placing environment in " Eric Nelson
2012-01-20 3:27 ` Jason Hui
2012-01-20 7:06 ` Dirk Behme
2012-01-20 7:48 ` Jason Hui
2012-01-20 8:47 ` Stefano Babic
2012-01-20 13:47 ` Eric Nelson
2012-01-20 13:43 ` Eric Nelson
2012-01-17 23:16 ` [U-Boot] mxc_spi refactoring (for mx6q) Marek Vasut
2012-01-18 11:51 ` Dirk Behme
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201201180227.17414.marek.vasut@gmail.com \
--to=marek.vasut@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox