From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V3 4/6] sf command: allow default chip select through CONFIG_SPI_FLASH_CS
Date: Wed, 25 Jan 2012 14:10:26 -0500 [thread overview]
Message-ID: <201201251410.29082.vapier@gentoo.org> (raw)
In-Reply-To: <4F201B5A.4010500@esd.eu>
On Wednesday 25 January 2012 10:10:18 Matthias Fuchs wrote:
> Can you also add a config option for the SPI bus number? I think these
> two need to handled in the same patch.
>
> So you could add this stuff:
>
> static int do_spi_flash_probe(int argc, char * const argv[])
> {
> +#ifdef CONFIG_SF_DEFAULT_BUS
> + unsigned int bus = CONFIG_SF_DEFAULT_BUS;
> +#else
> unsigned int bus = 0;
> +#endif
move the default logic to the top of the file like the existing
CONFIG_SF_DEFAULT_SPEED, then the code later on only needs to do:
unsigned int bus = CONFIG_SF_DEFAULT_BUS;
otherwise, this suggestion sounds good too
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120125/4e46854f/attachment.pgp>
next prev parent reply other threads:[~2012-01-25 19:10 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-24 16:18 [U-Boot] [PATCH V3 0/6] mxc_spi refactoring (for mx6q and mx6qsabrelite) Eric Nelson
2012-01-24 16:18 ` [U-Boot] [PATCH V3 1/6] mxc_spi: move machine specifics into CPU headers Eric Nelson
2012-01-24 16:18 ` [U-Boot] [PATCH V3 2/6] mx6q: Add support for ECSPI through mxc_spi driver Eric Nelson
2012-01-24 16:18 ` [U-Boot] [PATCH V3 3/6] mx6q: mx6qsabrelite: Add ECSPI support to the Sabrelite platform Eric Nelson
2012-01-24 16:18 ` [U-Boot] [PATCH V3 4/6] sf command: allow default chip select through CONFIG_SPI_FLASH_CS Eric Nelson
2012-01-24 16:27 ` Fabio Estevam
2012-01-24 18:08 ` Mike Frysinger
2012-01-27 1:22 ` Eric Nelson
2012-01-27 2:50 ` Mike Frysinger
2012-01-27 13:39 ` Eric Nelson
2012-01-25 15:10 ` Matthias Fuchs
2012-01-25 19:10 ` Mike Frysinger [this message]
2012-01-27 1:36 ` Eric Nelson
2012-01-27 2:52 ` Mike Frysinger
2012-01-24 16:18 ` [U-Boot] [PATCH V3 5/6] mx6q: mx6qsabrelite: Provide default chip-select for serial flash Eric Nelson
2012-01-24 16:18 ` [U-Boot] [PATCH V3 6/6] mx6q: mx6qsabrelite: Conditionally define macros for environment in " Eric Nelson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201201251410.29082.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox