* [U-Boot] [PATCH] TRATS: Fix uart gpio config
@ 2012-01-25 5:25 Chander Kashyap
2012-01-25 17:14 ` Marek Vasut
2012-01-26 8:22 ` Minkyu Kang
0 siblings, 2 replies; 3+ messages in thread
From: Chander Kashyap @ 2012-01-25 5:25 UTC (permalink / raw)
To: u-boot
It updates the missing gpio configuration of UART port.
Signed-off-by: Chander Kashyap <chander.kashyap@linaro.org>
Cc: HeungJun, Kim <riverful.kim@samsung.com>
---
board/samsung/trats/trats.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/board/samsung/trats/trats.c b/board/samsung/trats/trats.c
index f795ff0..4c9773d 100644
--- a/board/samsung/trats/trats.c
+++ b/board/samsung/trats/trats.c
@@ -337,7 +337,7 @@ static void board_uart_init(void)
int i;
/* UART0-UART1 GPIOs (part1) : 0x22222222 */
- for (i = 0; i < 7; i++) {
+ for (i = 0; i < 8; i++) {
s5p_gpio_set_pull(&gpio1->a0, i, GPIO_PULL_NONE);
s5p_gpio_cfg_pin(&gpio1->a0, i, GPIO_FUNC(0x2));
}
@@ -347,7 +347,7 @@ static void board_uart_init(void)
* GPA1CON[3] = I2C_3_SCL (3)
* GPA1CON[2] = I2C_3_SDA (3)
*/
- for (i = 0; i < 5; i++) {
+ for (i = 0; i < 6; i++) {
s5p_gpio_set_pull(&gpio1->a1, i, GPIO_PULL_NONE);
s5p_gpio_cfg_pin(&gpio1->a1, i,
GPIO_FUNC((i == 2 || i == 3) ? 0x3 : 0x2));
--
1.7.5.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* [U-Boot] [PATCH] TRATS: Fix uart gpio config
2012-01-25 5:25 [U-Boot] [PATCH] TRATS: Fix uart gpio config Chander Kashyap
@ 2012-01-25 17:14 ` Marek Vasut
2012-01-26 8:22 ` Minkyu Kang
1 sibling, 0 replies; 3+ messages in thread
From: Marek Vasut @ 2012-01-25 17:14 UTC (permalink / raw)
To: u-boot
> It updates the missing gpio configuration of UART port.
>
> Signed-off-by: Chander Kashyap <chander.kashyap@linaro.org>
> Cc: HeungJun, Kim <riverful.kim@samsung.com>
> ---
> board/samsung/trats/trats.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/board/samsung/trats/trats.c b/board/samsung/trats/trats.c
> index f795ff0..4c9773d 100644
> --- a/board/samsung/trats/trats.c
> +++ b/board/samsung/trats/trats.c
> @@ -337,7 +337,7 @@ static void board_uart_init(void)
> int i;
>
> /* UART0-UART1 GPIOs (part1) : 0x22222222 */
> - for (i = 0; i < 7; i++) {
> + for (i = 0; i < 8; i++) {
> s5p_gpio_set_pull(&gpio1->a0, i, GPIO_PULL_NONE);
> s5p_gpio_cfg_pin(&gpio1->a0, i, GPIO_FUNC(0x2));
> }
> @@ -347,7 +347,7 @@ static void board_uart_init(void)
> * GPA1CON[3] = I2C_3_SCL (3)
> * GPA1CON[2] = I2C_3_SDA (3)
> */
> - for (i = 0; i < 5; i++) {
> + for (i = 0; i < 6; i++) {
> s5p_gpio_set_pull(&gpio1->a1, i, GPIO_PULL_NONE);
> s5p_gpio_cfg_pin(&gpio1->a1, i,
> GPIO_FUNC((i == 2 || i == 3) ? 0x3 : 0x2));
Acked-by: Marek Vasut <marek.vasut@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* [U-Boot] [PATCH] TRATS: Fix uart gpio config
2012-01-25 5:25 [U-Boot] [PATCH] TRATS: Fix uart gpio config Chander Kashyap
2012-01-25 17:14 ` Marek Vasut
@ 2012-01-26 8:22 ` Minkyu Kang
1 sibling, 0 replies; 3+ messages in thread
From: Minkyu Kang @ 2012-01-26 8:22 UTC (permalink / raw)
To: u-boot
Dear Chander Kashyap,
On 25 January 2012 14:25, Chander Kashyap <chander.kashyap@linaro.org> wrote:
> It updates the missing gpio configuration of UART port.
>
> Signed-off-by: Chander Kashyap <chander.kashyap@linaro.org>
> Cc: HeungJun, Kim <riverful.kim@samsung.com>
> ---
> ?board/samsung/trats/trats.c | ? ?4 ++--
> ?1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/board/samsung/trats/trats.c b/board/samsung/trats/trats.c
> index f795ff0..4c9773d 100644
> --- a/board/samsung/trats/trats.c
> +++ b/board/samsung/trats/trats.c
> @@ -337,7 +337,7 @@ static void board_uart_init(void)
> ? ? ? ?int i;
>
> ? ? ? ?/* UART0-UART1 GPIOs (part1) : 0x22222222 */
> - ? ? ? for (i = 0; i < 7; i++) {
> + ? ? ? for (i = 0; i < 8; i++) {
> ? ? ? ? ? ? ? ?s5p_gpio_set_pull(&gpio1->a0, i, GPIO_PULL_NONE);
> ? ? ? ? ? ? ? ?s5p_gpio_cfg_pin(&gpio1->a0, i, GPIO_FUNC(0x2));
> ? ? ? ?}
> @@ -347,7 +347,7 @@ static void board_uart_init(void)
> ? ? ? ? * GPA1CON[3] = I2C_3_SCL (3)
> ? ? ? ? * GPA1CON[2] = I2C_3_SDA (3)
> ? ? ? ? */
> - ? ? ? for (i = 0; i < 5; i++) {
> + ? ? ? for (i = 0; i < 6; i++) {
> ? ? ? ? ? ? ? ?s5p_gpio_set_pull(&gpio1->a1, i, GPIO_PULL_NONE);
> ? ? ? ? ? ? ? ?s5p_gpio_cfg_pin(&gpio1->a1, i,
> ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?GPIO_FUNC((i == 2 || i == 3) ? 0x3 : 0x2));
> --
Actually we don't have to set all?of UARTs.
Because, we only use UART2 for serial.
I will post new patch for it.
Thanks
Minkyu Kang.
--
from. prom.
www.promsoft.net
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-01-26 8:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-25 5:25 [U-Boot] [PATCH] TRATS: Fix uart gpio config Chander Kashyap
2012-01-25 17:14 ` Marek Vasut
2012-01-26 8:22 ` Minkyu Kang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox