[U-Boot] [PATCH v3 1/5] arm bootm: Allow to pass board specified atags

Marek Vasut
2012-10-14T00:18:02Z

Dear Pali Roh?r,

> On Sunday 14 October 2012 01:43:25 Marek Vasut wrote:
> > Dear Pali Roh?r,
> >
> > ... missing commit message ...
>
> Is not subject enought?

Sorry, but no.

> > > Signed-off-by: Pali Roh?r <pali.rohar@gmail.com>
> > > ---
> > >
> > > arch/arm/include/asm/setup.h | 5 +++++
> > > arch/arm/lib/bootm.c | 5 +++++
> > > 2 files changed, 10 insertions(+)
> >
> > ... missing changelog ...
>
> There is no changelog. This patch is new in v3. I wrote it in
> mail [PATCH v3 0/5].

Good

> > > diff --git a/arch/arm/include/asm/setup.h
> > > b/arch/arm/include/asm/setup.h index 89df4dc..78a7fac 100644
> > > --- a/arch/arm/include/asm/setup.h
> > > +++ b/arch/arm/include/asm/setup.h
> > > @@ -267,3 +267,8 @@ struct meminfo {
> > >
> > > extern struct meminfo meminfo;
> > >
> > > #endif
> > >
> > > +
> > > +/*
> > > + * Board specified tags
> > > + */
> >
> > What's this ?
>
> Function which allow to pass board specified (non standard)
> atags.It is what you suggested:
> http://www.mail-archive.com/u-boot at lists.denx.de/msg82803.html

Oh, there's one more line below. OK.

> > > +void setup_board_tags(struct tag **in_params);
> > > diff --git a/arch/arm/lib/bootm.c b/arch/arm/lib/bootm.c
> > > index a9070d5..c092bfa 100644
> > > --- a/arch/arm/lib/bootm.c
> > > +++ b/arch/arm/lib/bootm.c
> > > @@ -266,6 +266,10 @@ static int create_fdt(bootm_headers_t
> > > *images)>
> > >
> > > }
> > > #endif
> > >
> > > +void __setup_board_tags(void) {}
> > > +void setup_board_tags(struct tag **in_params)
> > > + __attribute__((weak, alias("__setup_board_tags")));
> >
> > __weak void setup...(...) {} works just fine. Include
> > linux/compiler.h
>
> I did not know about __weak. I will change it.

Best regards,
Marek Vasut