From: Marek Vasut <marek.vasut@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v6 1/3] PXA: PXA27x Matrix keypad driver
Date: Wed, 25 Jan 2012 22:55:00 +0100 [thread overview]
Message-ID: <201201252255.00928.marek.vasut@gmail.com> (raw)
In-Reply-To: <CA+E=qVecx_k4gikp=Ksos0ALV0zXEq6eY+uzaSELunE9zFwZEA@mail.gmail.com>
> 2012/1/25 Marek Vasut <marek.vasut@gmail.com>:
> >> From: Marek Vasut <marek.vasut@gmail.com>
> >>
> >> Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
> >> Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com>
> >> [vasily: adapted Marek's old version for newer u-boot,
> >> fixed multiple keypresses handling]
> >
> > Fine ... albert, can you comment on it?
> >
> > Vasily, do you think this code is good? I want an honest answer!
>
> Well, it's overcomplicated due to missing _generic_ keyboard support in
> u-boot.
Then create such code!
> It's possible to separate buffer handling, layout management into
> some "keyboard-core",
> so keyboard driver provides only key press/release events to core and
> then core decides
> what to do if we have multiple keys pressed, if modifier is pressed, etc,
> etc...
Great idea, let's put this patch on hold and implement the support layer then!
>
> Anyway, for me this code is easy to understand, but it's for now. So
> if you want _really_ honest answer -- wait for few weeks
> so I can re-review it with fresh view.
I don't mind. But maybe you can really implement the keyboard support layer and
simply add this as a clean and easy driver.
M
>
> Regards
> Vasily
prev parent reply other threads:[~2012-01-25 21:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-25 19:54 [U-Boot] [PATCH v6 1/3] PXA: PXA27x Matrix keypad driver Vasily Khoruzhick
2012-01-25 19:54 ` [U-Boot] [PATCH v6 2/3] zipitz2: enable pxa27x_mkp driver Vasily Khoruzhick
2012-01-25 19:54 ` [U-Boot] [PATCH v6 3/3] zipitz2: use pxa_mmc_gen as MMC driver Vasily Khoruzhick
2012-01-25 20:59 ` [U-Boot] [PATCH v6 1/3] PXA: PXA27x Matrix keypad driver Marek Vasut
2012-01-25 21:39 ` Vasily Khoruzhick
2012-01-25 21:55 ` Marek Vasut [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201201252255.00928.marek.vasut@gmail.com \
--to=marek.vasut@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox