From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Wed, 25 Jan 2012 23:01:38 +0100 Subject: [U-Boot] [PATCH 11/14] New config variable CONFIG_PREMONITOR In-Reply-To: <3237864.ES65q2g7EX@pali> References: <1327415291-13260-1-git-send-email-pali.rohar@gmail.com> <201201252228.17208.marek.vasut@gmail.com> <3237864.ES65q2g7EX@pali> Message-ID: <201201252301.38328.marek.vasut@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de > On Wednesday 25 January 2012 22:28:17 Marek Vasut wrote: > > > On Wednesday 25 January 2012 21:51:38 Marek Vasut wrote: > > > > > On Wednesday 25 January 2012 19:12:51 Marek Vasut wrote: > > > > > > > * if defined run env "premonitor" before Main Loop for Monitor > > > > > > > Processing > > > > > > > > > > > > What is this good for? > > > > > > > > > > before running monitor loop I'd like write some info to console > > > > > (specific board info, board commands, board macros). but if these > > > > > info will be written in preboot it can be deleted by menu section. > > > > > > > > The "menu" here, you refer to the thing you implemented? So fix that > > > > instead of introducing broken code and a pile of workarounds. > > > > > > With "menu" I mean env menucmd. U-Boot run command stored in env > > > menucmd after preboot and before monitor loop. For example in menucmd > > > can be my bootmenu, but there are no problems - no broken code! My > > > bootmenu clear screan and show menu, so anything printed before menu > > > entries will be deleted. This is not bug - Also in Grub or LILO is > > > debug/output log cleaned when showing menu entries. > > > > Ok anyway, but you implemented custom menu system anyway ... so let's > > clear this first, is common/menu.c useless for your application? > > I do not know. I created my bootmenu before menu.c was integrated into > u-boot. I did not looked at menu.c yet - I do not know what is in menu.c > implemented. Please go through it, we don't need two separate implementations of the same thing. If you can't use it as it, just augment it and submit a patch for it.