From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/6] microblaze: Enable several ethernet driver compilation
Date: Sun, 29 Jan 2012 00:27:08 +0100 [thread overview]
Message-ID: <20120128232708.8AE841FC08D@gemini.denx.de> (raw)
In-Reply-To: <1327740947.3638.16.camel@keto>
Dear Stephan Linz,
In message <1327740947.3638.16.camel@keto> you wrote:
>
> > > #define CONFIG_ETHADDR 00:E0:0C:00:00:FD
> > > +#define CONFIG_ETH1ADDR 00:E0:0C:00:00:FC
> >
> > err, i think these need to get dropped. boards should not be hardcoding mac
> > addresses in their configs.
>
> OK, I think so too. I can left at least one MAC address as it was in the
> original board configuration. I think we need this for a rapid system
> startup without a default configuration in ROM. IMHO there are many many
> boards that are going this way ...
Please drop it. As Mike pointed out, it is not acceptable for
mainline code.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
What was sliced bread the greatest thing since?
next prev parent reply other threads:[~2012-01-28 23:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-21 20:59 [U-Boot] LL TEMAC v9 refactored Stephan Linz
2012-01-21 21:02 ` [U-Boot] [PATCH 1/6] net: ll_temac: Add LL TEMAC driver to u-boot Stephan Linz
2012-01-26 15:07 ` Michal Simek
2012-01-26 22:30 ` Stephan Linz
2012-01-21 21:02 ` [U-Boot] [PATCH 2/6] microblaze: Enable several ethernet driver compilation Stephan Linz
2012-01-27 3:58 ` Mike Frysinger
2012-01-28 8:55 ` Stephan Linz
2012-01-28 21:06 ` Mike Frysinger
2012-01-28 23:27 ` Wolfgang Denk [this message]
2012-01-21 21:02 ` [U-Boot] [PATCH 3/6] microblaze: Wire up LL_TEMAC driver initialization Stephan Linz
2012-01-21 21:02 ` [U-Boot] [PATCH 4/6] microblaze: Enable phylib and mii support Stephan Linz
2012-01-21 21:02 ` [U-Boot] [PATCH 5/6] microblaze: Enable TFTP put command Stephan Linz
2012-01-21 21:02 ` [U-Boot] [PATCH 6/6] microblaze: Add faked LL_TEMAC driver configuration Stephan Linz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120128232708.8AE841FC08D@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox