public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marek.vasut@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] i.MX28: Fix ref_cpu clock setup
Date: Thu, 2 Feb 2012 20:22:06 +0100	[thread overview]
Message-ID: <201202022022.06395.marek.vasut@gmail.com> (raw)
In-Reply-To: <6EA3E0BCC03CC34B89B01BD57ECBC718F52AF0@POBOX.postoffice.danego.net>

> Hi,
> 
> In addition to my first patch, please consider accepting this patch too.
> It prevents needless switching on and off PLL bypass mode and it
> allow single stepping through the SPL.

Hi,

this is how the imx-bootlets does it though. It's likely that FSL wants the PLL0 
to run from XTAL when doing power configuration?

M
> 
> This patch removes mx28_power_clock2xtal, because all this function
> does is switching to reset-defaults, at a moment only reset defaults are
> already active.
> 
> It removes mx28_power_clock2pll becasue it is incomplete and
> because mx28_mem_init_clock does the same thing a little later on
> and does it corectly.

Maybe clock2pll should be fixed then ?

M

> 
> Signed-off-by: Robert Delien (robert at delien.nl)
> 
> ________________________________________
> From: Marek Vasut [marek.vasut at gmail.com]
> Sent: 26 January 2012 19:32
> To: Fabio Estevam
> Cc: Robert Deli?n; u-boot at lists.denx.de
> Subject: Re: mx28 spl power cpu clock configuration
> 
> > Hi Robert,
> > 
> > On 1/25/12, Marek Vasut <marek.vasut@gmail.com> wrote:
> > >> Shouldn't we configure clkctrl_frac0 - or at least disable CPU clock
> > >> gating - before disabling PLL bypass?
> > > 
> > > This seems reasonable. Fabio, can you comment?
> > 
> > Could you please post a patch with your proposed change so that we can
> > test it?
> 
> Hi Fabio,
> 
> I bought a really crappy custom board a few days ago (some china-made crap)
> sporting mx287, but apparently I'm hitting similar issue you do here.
> 
> When I swap power_init and mem_init though, the board boots fine, othervise
> it hangs.
> 
> M

       reply	other threads:[~2012-02-02 19:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <6EA3E0BCC03CC34B89B01BD57ECBC718F52AF0@POBOX.postoffice.danego.net>
2012-02-02 19:22 ` Marek Vasut [this message]
2012-02-03 10:57   ` [U-Boot] [PATCH 2/2] i.MX28: Fix ref_cpu clock setup Robert Deliën
2012-02-03 12:21     ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201202022022.06395.marek.vasut@gmail.com \
    --to=marek.vasut@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox