From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Frysinger Date: Fri, 3 Feb 2012 06:44:13 -0500 Subject: [U-Boot] [PATCH 01/28] net: Remove volatile from all of net except the eth driver interface In-Reply-To: <1327020811-1538-2-git-send-email-joe.hershberger@ni.com> References: <1327020811-1538-1-git-send-email-joe.hershberger@ni.com> <1327020811-1538-2-git-send-email-joe.hershberger@ni.com> Message-ID: <201202030644.14018.vapier@gentoo.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de in general, i like this. my only concern would be the drivers that might break due to incorrect cache management (which the volatile markers happen to work around for them). having the API accept a volatile but then casting it away puts us in a worse place i think. on one hand, our API is saying "we treat it as volatile" when we really don't, so any drivers that call it with a volatile don't get build warnings. i'd just drop it from all of the net API so that the drivers which do call with a volatile pointer get a build warning -- now the driver maintainer knows they have to at least look at something. -mike -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: This is a digitally signed message part. URL: