From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Frysinger Date: Fri, 3 Feb 2012 07:10:02 -0500 Subject: [U-Boot] [PATCH 10/28] net: cosmetic: Improve variable names and code readability In-Reply-To: References: <1327020811-1538-1-git-send-email-joe.hershberger@ni.com> <1327020811-1538-11-git-send-email-joe.hershberger@ni.com> Message-ID: <201202030710.04232.vapier@gentoo.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tuesday 24 January 2012 01:19:14 Simon Glass wrote: > On Thu, Jan 19, 2012 at 4:53 PM, Joe Hershberger wrote: > > Rename parameter len to payload_len in NetSendUDPPacket: this name > > more explicitly claims that it does not include the header size > > Rename CDPHandler to CDPReceive: this is not called as a handler, > > so don't name it that way > > Rename OPT_SIZE to OPT_FIELD_SIZE: clearer constant name and also > > remove related BOOTP_SIZE which was unused and doesn't take into > > account VLAN packets > > Rename tmp to reply_ip_addr in arp.c > > Alphabetize includes in net.c > > Replace magic numbers in arp.c with constants > > Add a more explicit comment about 802.2 > > Yes but why lump all of these together? It would benefit from 3-4 > separate commits IMO. +1 -mike -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: This is a digitally signed message part. URL: