From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Frysinger Date: Fri, 3 Feb 2012 07:13:35 -0500 Subject: [U-Boot] [PATCH 13/28] net: Refactor bootp packet length computations In-Reply-To: References: <1327020811-1538-1-git-send-email-joe.hershberger@ni.com> Message-ID: <201202030713.36900.vapier@gentoo.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tuesday 24 January 2012 02:15:41 Joe Hershberger wrote: > On Tue, Jan 24, 2012 at 1:05 AM, Simon Glass wrote: > > On Thu, Jan 19, 2012 at 4:53 PM, Joe Hershberger wrote: > >> - debug("Transmitting DHCPREQUEST packet: len = %d\n", pktlen); > >> #ifdef CONFIG_BOOTP_DHCP_REQUEST_DELAY > >> udelay(CONFIG_BOOTP_DHCP_REQUEST_DELAY); > >> #endif /* CONFIG_BOOTP_DHCP_REQUEST_DELAY */ > >> + debug("Transmitting DHCPREQUEST packet: len = %d\n", pktlen); > > > > Did you move this on purpose? > > Yes... I figured a transmit debug message should be close to the > transmit... not before a delay. generally we frown on these sort of side-commits ... -mike -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: This is a digitally signed message part. URL: