From: Marek Vasut <marek.vasut@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] i.MX28: Fix ref_cpu clock setup
Date: Fri, 3 Feb 2012 13:27:42 +0100 [thread overview]
Message-ID: <201202031327.42870.marek.vasut@gmail.com> (raw)
In-Reply-To: <6EA3E0BCC03CC34B89B01BD57ECBC718F56DAB@POBOX.postoffice.danego.net>
> Hi,
>
> > you're only writing data to the register, not clearing them. So maybe
> > some bits remain set?
>
> The assignment will work here. There're only 8 bits, of which 6 are the
> fractional divider, one is de read-only stable indicator (unaffected by
> writes) and the last one is the gating bit.
> The assignment configures the fractional divider and clears the gating.
>
> > Anyway, can you please submit proper patch with git send-email? Thanks!
>
> Will do; Working on that! And you're welcome.
Awesome. So after reading your replies, let's just rename mx28_reg to
mx28_reg_32 and introduce mx28_reg_8 for this particular problem.
M
>
> Cheers,
>
> Robert.1
next prev parent reply other threads:[~2012-02-03 12:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <6EA3E0BCC03CC34B89B01BD57ECBC718F529B9@POBOX.postoffice.danego.net>
2012-02-02 16:58 ` [U-Boot] [PATCH 1/2] i.MX28: Fix ref_cpu clock setup Fabio Estevam
2012-02-02 17:09 ` Fabio Estevam
2012-02-02 17:21 ` Robert Deliën
2012-02-02 19:03 ` Fabio Estevam
2012-02-03 10:38 ` Robert Deliën
2012-02-03 10:32 ` Robert Deliën
2012-02-02 19:19 ` Marek Vasut
2012-02-03 10:42 ` Robert Deliën
2012-02-03 12:27 ` Marek Vasut [this message]
2012-02-03 14:00 ` Robert Deliën
2012-02-03 14:09 ` Marek Vasut
2012-02-03 14:18 ` Robert Deliën
2012-02-03 14:28 ` Marek Vasut
2012-02-03 7:23 ` Marek Vasut
2012-02-03 11:13 ` Robert Deliën
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201202031327.42870.marek.vasut@gmail.com \
--to=marek.vasut@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox