public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] RFC: create u-boot-common.lds
Date: Sun, 5 Feb 2012 22:24:02 -0500	[thread overview]
Message-ID: <201202052224.04780.vapier@gentoo.org> (raw)
In-Reply-To: <CALButCKdSiCunoXf0orubBw+BYE9Sh3DeAYOZAORB1_1nMYmCw@mail.gmail.com>

On Sunday 05 February 2012 17:07:41 Graeme Russ wrote:
> On Mon, Feb 6, 2012 at 8:01 AM, Mike Frysinger wrote:
> > On Saturday 04 February 2012 22:02:45 Troy Kisky wrote:
> >> --- /dev/null
> >> +++ b/u-boot-common.lds
> >> 
> >> +     . = ALIGN(4);
> >> +     __u_boot_cmd_start = .;
> >> +     .u_boot_cmd : {
> >> +             KEEP(*(.u_boot_cmd))
> >> +     }
> >> +     __u_boot_cmd_end = .;
> > 
> > rather than storing this in the top level dir, i'd suggest going the
> > linux route and add a include/asm-generic/u-boot.lds.h header.  then we
> > can migrate
> 
> Except it's not a 'header' :)

what Troy has posted isn't a header, but what i'm suggesting is.  Linux's 
vmlinux.lds.h does things like:
	#define DISCARDS \
		/DISCARDS/ : { \
		EXIT_TEXT \
		*(.discard) \
		}

and then the arch linker scripts just use:
	DISCARDS

> > people over time and piece by piece without having to worry about
> > breaking everyone at once ...
> 
> Here we go again ;) - Queue the 'what incentive will maintainers have to
> migrate to the common case' discussion...

it isn't just that.  i don't think a single u-boot.lds for every arch is 
feasible.  the kernel method allows all the common pieces to be in a common 
header, and then the arches to expand the specific pieces in the specific order.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120205/78e7272a/attachment.pgp>

  reply	other threads:[~2012-02-06  3:24 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-05  3:02 [U-Boot] [PATCH 1/2] RFC: create u-boot-common.lds Troy Kisky
2012-02-05  3:02 ` [U-Boot] [PATCH 2/2] RFC: Let linker create phy array Troy Kisky
2012-02-05  3:38   ` Mike Frysinger
2012-02-05  6:16     ` Dirk Behme
2012-02-05 13:26     ` Albert ARIBAUD
2012-02-05 20:40       ` Mike Frysinger
2012-02-06 20:53         ` Albert ARIBAUD
2012-02-06 18:48     ` Troy Kisky
2012-02-06 19:07       ` Mike Frysinger
2012-02-06 20:17         ` Troy Kisky
2012-02-06 20:56           ` Albert ARIBAUD
2012-02-06 20:57           ` Mike Frysinger
2012-02-06 21:01             ` Albert ARIBAUD
2012-02-07 15:20               ` Mike Frysinger
2012-02-10 19:39                 ` Albert ARIBAUD
2012-02-10 20:32                   ` Mike Frysinger
2012-02-10 20:57                     ` Albert ARIBAUD
2012-02-10 21:41                       ` Mike Frysinger
2012-02-12 14:45                         ` Albert ARIBAUD
2012-02-06 21:44             ` Troy Kisky
2012-02-07 15:21               ` Mike Frysinger
2012-02-05 21:01 ` [U-Boot] [PATCH 1/2] RFC: create u-boot-common.lds Mike Frysinger
2012-02-05 22:07   ` Graeme Russ
2012-02-06  3:24     ` Mike Frysinger [this message]
2012-02-06  3:43       ` Graeme Russ
2012-02-06  4:27         ` Mike Frysinger
2012-02-06  4:34           ` Graeme Russ
2012-02-06  5:48             ` Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201202052224.04780.vapier@gentoo.org \
    --to=vapier@gentoo.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox