public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Thierry Reding <thierry.reding@avionic-design.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Ethernut 5: fix build error for board_mmc_getcd()
Date: Mon, 6 Feb 2012 14:38:13 +0100	[thread overview]
Message-ID: <20120206133812.GA7321@avionic-0098.adnet.avionic-design.de> (raw)
In-Reply-To: <1328532584-17986-1-git-send-email-prabhakar.csengg@gmail.com>

* Prabhakar Lad wrote:
> Fix build error for ethernut5 and mx6qarm2 board due
> to prototype change for function  board_mmc_getcd()
> ethernut5.c:238: error: conflicting types for 'board_mmc_getcd'
> u-boot/include/mmc.h:318: note: previous declaration of 'board_mmc_getcd' was here
> make[2]: *** [ethernut5.o] Error 1
> 
> Signed-off-by: Prabhakar Lad <prabhakar.csengg@gmail.com>
> ---
>  board/egnite/ethernut5/ethernut5.c |    5 ++---
>  1 files changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/board/egnite/ethernut5/ethernut5.c b/board/egnite/ethernut5/ethernut5.c
> index e42e91e..fd021a3 100644
> --- a/board/egnite/ethernut5/ethernut5.c
> +++ b/board/egnite/ethernut5/ethernut5.c
> @@ -235,10 +235,9 @@ int board_mmc_init(bd_t *bd)
>  	return atmel_mci_init((void *)ATMEL_BASE_MCI);
>  }
>  
> -int board_mmc_getcd(u8 *cd, struct mmc *mmc)
> +int board_mmc_getcd(struct mmc *mmc)
>  {
> -	*cd = at91_get_pio_value(CONFIG_SYS_MMC_CD_PIN) ? 1 : 0;
> -	return 0;
> +	return !at91_get_pio_value(CONFIG_SYS_MMC_CD_PIN);
>  }
>  #endif

Reviewed-by: Thierry Reding <thierry.reding@avionic-design.de>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120206/953a038a/attachment.pgp>

  reply	other threads:[~2012-02-06 13:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-06 12:49 [U-Boot] [PATCH] Ethernut 5: fix build error for board_mmc_getcd() Prabhakar Lad
2012-02-06 13:38 ` Thierry Reding [this message]
2012-02-19  9:49 ` Albert ARIBAUD
2012-02-20  4:45   ` Prabhakar Lad

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120206133812.GA7321@avionic-0098.adnet.avionic-design.de \
    --to=thierry.reding@avionic-design.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox