public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marek.vasut@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] v2 i.MX28: Fix ref_cpu clock setup
Date: Mon, 6 Feb 2012 14:15:44 +0100	[thread overview]
Message-ID: <201202061415.44714.marek.vasut@gmail.com> (raw)
In-Reply-To: <6EA3E0BCC03CC34B89B01BD57ECBC718F6529D@POBOX.postoffice.danego.net>

> Hi,
> 
> > That's why I put the ternary operator there ?
> 
> Ah; without anything behind it, it really just looked like a question mark.
> But using a ternary caters only for a set of two. So enumeration would
> be better ideed.
> 
> > It's impossible to review like this though and much more prone to pull in
> > bugs.
> 
> Can you point me to a good and tutorial for GIT then? Just a brief
> description of the work flow, from cloning the public archive, to
> submitting patches with a couple of examples.

I just sent you an howto in a subsequent mail.
> 
> Now, for every bit of rework, I clone a new archive and manually
> patch in all my changes to make a clean patch.

No, it's really simple, see the email.

> That is two hours of work
> and I'm not willing to spend that time on every remark.

Yep ... basically, you need to learn:

git rebase -i (select patches you want to edit, reword ...)
git commit --amend (add stuff to top-of-head patch)

And the stuff I sent you -- "git reset" to reset changes from the index, git add 
-p to add changes selectively.

M

> 
> Cheers,
> 
>         Robert.

  reply	other threads:[~2012-02-06 13:15 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <6EA3E0BCC03CC34B89B01BD57ECBC718F65163@POBOX.postoffice.danego.net>
2012-02-06 12:20 ` [U-Boot] [PATCH 1/2] v2 i.MX28: Fix ref_cpu clock setup Marek Vasut
2012-02-06 12:33   ` Robert Deliën
2012-02-06 12:49     ` Marek Vasut
2012-02-06 13:03       ` Robert Deliën
2012-02-06 13:15         ` Marek Vasut [this message]
2012-02-06 12:56     ` Marek Vasut
2012-02-06 14:28       ` Robert Deliën
2012-02-06 14:40         ` Marek Vasut
2012-02-06 12:20 ` Marek Vasut
2012-02-06 12:38   ` Robert Deliën
2012-02-06 12:49     ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201202061415.44714.marek.vasut@gmail.com \
    --to=marek.vasut@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox