From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marek.vasut@gmail.com>
Date: Mon, 6 Feb 2012 14:15:44 +0100
Subject: [U-Boot] [PATCH 1/2] v2 i.MX28: Fix ref_cpu clock setup
In-Reply-To: <6EA3E0BCC03CC34B89B01BD57ECBC718F6529D@POBOX.postoffice.danego.net>
References: <6EA3E0BCC03CC34B89B01BD57ECBC718F65163@POBOX.postoffice.danego.net>
	<201202061349.03429.marek.vasut@gmail.com>
	<6EA3E0BCC03CC34B89B01BD57ECBC718F6529D@POBOX.postoffice.danego.net>
Message-ID: <201202061415.44714.marek.vasut@gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

> Hi,
> 
> > That's why I put the ternary operator there ?
> 
> Ah; without anything behind it, it really just looked like a question mark.
> But using a ternary caters only for a set of two. So enumeration would
> be better ideed.
> 
> > It's impossible to review like this though and much more prone to pull in
> > bugs.
> 
> Can you point me to a good and tutorial for GIT then? Just a brief
> description of the work flow, from cloning the public archive, to
> submitting patches with a couple of examples.

I just sent you an howto in a subsequent mail.
> 
> Now, for every bit of rework, I clone a new archive and manually
> patch in all my changes to make a clean patch.

No, it's really simple, see the email.

> That is two hours of work
> and I'm not willing to spend that time on every remark.

Yep ... basically, you need to learn:

git rebase -i (select patches you want to edit, reword ...)
git commit --amend (add stuff to top-of-head patch)

And the stuff I sent you -- "git reset" to reset changes from the index, git add 
-p to add changes selectively.

M

> 
> Cheers,
> 
>         Robert.