From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 2/6] config.mk: Make cc-option create a file under include/generated
Date: Tue, 14 Feb 2012 00:43:56 -0500 [thread overview]
Message-ID: <201202140043.57935.vapier@gentoo.org> (raw)
In-Reply-To: <1329174126-21460-3-git-send-email-trini@ti.com>
On Monday 13 February 2012 18:02:02 Tom Rini wrote:
> isnt possible with /dev/null.
isn't
> --- a/config.mk
> +++ b/config.mk
>
> -cc-option-sys = $(shell if $(CC) $(CFLAGS) $(1) -S -o /dev/null -xc /dev/null \
> - > /dev/null 2>&1; then \
> +cc-option-sys = $(shell mkdir -p $(dir $(CC_TEST_FILE)); \
> + touch $(CC_TEST_FILE); \
> + if $(CC) $(CFLAGS) $(1) -S -o $(CC_TEST_FILE) \
> + -xc $(CC_TEST_FILE) > /dev/null 2>&1; then \
why do you need to touch the file first ? why do you source this test file
instead of continuing to source /dev/null ? don't you run into problems if
you use cc-option-sys more than once and a previous run wrote something to
that file ? then cc-option-sys could fail on later runs ...
seems like you should drop the `touch` and keep the -xc /dev/null and only
change the -o to $(CC_TEST_FILE) ...
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120214/374a52b7/attachment.pgp>
next prev parent reply other threads:[~2012-02-14 5:43 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-08 22:58 [U-Boot] [PATCH 1/6] .gitignore: Add .su files Tom Rini
2012-02-08 22:58 ` [U-Boot] [PATCH 2/6] config.mk: Make cc-option create a file under include/generated Tom Rini
2012-02-08 22:58 ` [U-Boot] [PATCH 3/6] arm: Check for -fstack-usage support Tom Rini
2012-02-13 22:30 ` Wolfgang Denk
2012-02-08 22:58 ` [U-Boot] [PATCH 4/6] spl.c: Use __noreturn decorator Tom Rini
2012-02-08 22:58 ` [U-Boot] [PATCH 5/6] README: Add more SPL config options Tom Rini
2012-02-08 22:58 ` [U-Boot] [PATCH 6/6] SPL: Add README.omap3 Tom Rini
2012-02-08 23:08 ` Peter Meerwald
2012-02-08 23:19 ` Tom Rini
2012-02-09 3:36 ` [U-Boot] [PATCH 1/6] .gitignore: Add .su files Mike Frysinger
2012-02-13 23:02 ` [U-Boot] [PATCH v2 0/6] SPL-related documentation / checking Tom Rini
2012-02-14 17:29 ` [U-Boot] [PATCH v3 " Tom Rini
2012-02-14 17:29 ` [U-Boot] [PATCH v3 1/6] .gitignore: Add .su files Tom Rini
2012-02-14 17:29 ` [U-Boot] [PATCH v3 2/6] config.mk: Make cc-option create a file under include/generated Tom Rini
2012-02-14 17:29 ` [U-Boot] [PATCH v3 3/6] config.mk: Check for -fstack-usage support Tom Rini
2012-02-20 23:50 ` [U-Boot] [PATCH v4 " Tom Rini
2012-02-14 17:29 ` [U-Boot] [PATCH v3 4/6] spl.c: Use __noreturn decorator Tom Rini
2012-02-14 17:29 ` [U-Boot] [PATCH v3 5/6] README: document more SPL config options Tom Rini
2012-02-14 17:29 ` [U-Boot] [PATCH v3 6/6] SPL: Add README.omap3 Tom Rini
2012-02-14 18:43 ` Mike Frysinger
2012-02-14 19:51 ` Tom Rini
2012-02-20 23:27 ` [U-Boot] [PATCH v4 " Tom Rini
2012-02-13 23:02 ` [U-Boot] [PATCH v2 1/6] .gitignore: Add .su files Tom Rini
2012-02-13 23:02 ` [U-Boot] [PATCH v2 2/6] config.mk: Make cc-option create a file under include/generated Tom Rini
2012-02-14 5:43 ` Mike Frysinger [this message]
2012-02-14 14:35 ` Tom Rini
2012-02-13 23:02 ` [U-Boot] [PATCH v2 3/6] config.mk: Check for -fstack-usage support Tom Rini
2012-02-14 5:39 ` Mike Frysinger
2012-02-13 23:02 ` [U-Boot] [PATCH v2 4/6] spl.c: Use __noreturn decorator Tom Rini
2012-02-14 5:39 ` Mike Frysinger
2012-02-13 23:02 ` [U-Boot] [PATCH v2 5/6] README: Add more SPL config options Tom Rini
2012-02-14 5:40 ` Mike Frysinger
2012-02-13 23:02 ` [U-Boot] [PATCH v2 6/6] SPL: Add README.omap3 Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201202140043.57935.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox