From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Frysinger Date: Tue, 14 Feb 2012 01:49:15 -0500 Subject: [U-Boot] [PATCH 04/28] net: Make the MAC-seeded random number generator available to /net In-Reply-To: References: <1327020811-1538-1-git-send-email-joe.hershberger@ni.com> <201202030651.17516.vapier@gentoo.org> Message-ID: <201202140149.16643.vapier@gentoo.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Friday 10 February 2012 16:51:00 Joe Hershberger wrote: > On Fri, Feb 3, 2012 at 5:51 AM, Mike Frysinger wrote: > > On Thursday 19 January 2012 19:53:07 Joe Hershberger wrote: > >> --- a/net/bootp.c > >> +++ b/net/bootp.c > >> > >> +#ifdef CONFIG_BOOTP_RANDOM_DELAY > >> +#include "net_rand.h" > >> +#endif > > > > let's push this CONFIG_xxx check into net_rand.h so we don't have to > > check it every time we include the file > > In this case, it doesn't make sense. The rand is enabled based on > other features that need it... it does not have a config of its own. > As a result, putting this in the header would make it worse. This > guard is still needed in bootp.c, since rand is only needed when that > subfeature is enabled. For link-local, it will always be included. i'm not sure guarding the include really gains us anything. i'm inclined to just always include it and be done. -mike -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: This is a digitally signed message part. URL: