public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marek.vasut@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] i.MX28: Fix ref_cpu clock setup
Date: Tue, 14 Feb 2012 13:34:20 +0100	[thread overview]
Message-ID: <201202141334.20489.marek.vasut@gmail.com> (raw)
In-Reply-To: <6EA3E0BCC03CC34B89B01BD57ECBC718F80295@POBOX.postoffice.danego.net>

> > Robert, I tested first three patches on my board and it refuses to boot.
> > Why?
> 
> The problem is in here:
> io_reg = MXC_IOCLK1 - io; /* Register order is reversed */
> 
> I will rework and resubmit the patches 'soon'. I'm a bit numb of reworking
> and resubmitting and I just received a board to bringup last week, and
> that's got my priority.

git rebase -i HEAD~3

(if you have the patch you want to rework 3 patches deep)

Change "pick" to the left of the patch to "edit"

Do the change in the file.

git add <file>

git rebase --continue

<submit>

> 
> BTW: It seems that mx28evk DDR2 is overclocked a bit. For example tRCD is
> set to 3, where it should be. I didn't look into all the other settings
> yet, because lowering the clock helps for my board, for now.

Lowering the clock to what ? I was pondering about this too, the settings in 
spl_mem_init are for DENX m28 board, so maybe someone should abstract that out.

M

  reply	other threads:[~2012-02-14 12:34 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-07 13:16 [U-Boot] [PATCH] i.MX28: Fix ref_cpu clock setup robert at delien.nl
2012-02-07 13:16 ` [U-Boot] [PATCH 1/4 v4] Renamed mx28_register to mx28_register_32 to prepare for mx28_register_8 robert at delien.nl
2012-02-07 13:16 ` [U-Boot] [PATCH 2/4 v4] Introducing 8-bit wide register, mx28_register_8 robert at delien.nl
2012-02-07 13:16 ` [U-Boot] [PATCH 3/4 v4] Fix erroneous 32-bit access to hw_clkctrl_frac0 and hw_clkctrl_frac1 registers robert at delien.nl
2012-02-07 13:16 ` [U-Boot] [PATCH 4/4 v4] Preventing needless switching on and off PLL bypass mode, allowing allow single-stepping through the SPL robert at delien.nl
2012-02-07 16:53   ` Marek Vasut
2012-02-07 16:57     ` Fabio Estevam
2012-02-08  2:27     ` Fabio Estevam
2012-02-08  2:43       ` Marek Vasut
     [not found]         ` <F0D11DBEB504444BA6C8DA07A395A35A0438D1@039-SN2MPN1-012.039d.mgd.msft.net>
2012-02-08  2:46           ` Marek Vasut
2012-02-08  7:49             ` Robert Deliën
     [not found]             ` <F0D11DBEB504444BA6C8DA07A395A35A043906@039-SN2MPN1-012.039d.mgd.msft.net>
2012-02-08  7:51               ` Robert Deliën
2012-02-08  7:45           ` Robert Deliën
2012-02-08  7:42         ` Robert Deliën
2012-02-08  7:38       ` Robert Deliën
2012-02-07 17:17 ` [U-Boot] [PATCH] i.MX28: Fix ref_cpu clock setup Marek Vasut
2012-02-07 19:08   ` Robert Deliën
2012-02-07 19:28   ` Robert Deliën
2012-02-07 20:59     ` Marek Vasut
2012-02-08  7:32       ` Robert Deliën
2012-02-08 16:28         ` Marek Vasut
2012-02-14 12:21   ` Robert Deliën
2012-02-14 12:34     ` Marek Vasut [this message]
2012-02-14 13:27       ` Robert Deliën

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201202141334.20489.marek.vasut@gmail.com \
    --to=marek.vasut@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox