[U-Boot] [PATCH 0/4 v5] i.MX28: Fix ref_cpu clock setup

[U-Boot] [PATCH 0/4 v5] i.MX28: Fix ref_cpu clock setup

[Marek Vasut]

> From: Robert Delien <robert@delien.nl>
> 
> This set of patches fixes ref_cpu clock setup.
> 
> Robert Delien (4):
>   Renamed mx28_register to mx28_register_32 to prepare for
>     mx28_register_8
>   Introducing 8-bit wide register, mx28_register_8
>   Fix erroneous 32-bit access to hw_clkctrl_frac0 and hw_clkctrl_frac1
>     registers
>   Preventing needless switching on and off PLL bypass mode, allowing
>     allow single-stepping through the SPL
> 
>  arch/arm/cpu/arm926ejs/mx28/clock.c           |   74 +++-----
>  arch/arm/cpu/arm926ejs/mx28/iomux.c           |    6 +-
>  arch/arm/cpu/arm926ejs/mx28/mx28.c            |    6 +-
>  arch/arm/cpu/arm926ejs/mx28/spl_mem_init.c    |   30 ++--
>  arch/arm/cpu/arm926ejs/mx28/spl_power_init.c  |   24 ---
>  arch/arm/include/asm/arch-mx28/regs-apbh.h    |  254
> ++++++++++++------------ arch/arm/include/asm/arch-mx28/regs-bch.h     |  
> 42 ++--
>  arch/arm/include/asm/arch-mx28/regs-clkctrl.h |   98 ++++------
>  arch/arm/include/asm/arch-mx28/regs-common.h  |   28 ++-
>  arch/arm/include/asm/arch-mx28/regs-gpmi.h    |   26 ++--
>  arch/arm/include/asm/arch-mx28/regs-i2c.h     |   28 ++--
>  arch/arm/include/asm/arch-mx28/regs-ocotp.h   |   86 ++++----
>  arch/arm/include/asm/arch-mx28/regs-pinctrl.h |  168 ++++++++--------
>  arch/arm/include/asm/arch-mx28/regs-power.h   |   28 ++--
>  arch/arm/include/asm/arch-mx28/regs-rtc.h     |   28 ++--
>  arch/arm/include/asm/arch-mx28/regs-ssp.h     |   40 ++--
>  arch/arm/include/asm/arch-mx28/regs-timrot.h  |   38 ++--
>  arch/arm/include/asm/arch-mx28/regs-usbphy.h  |   20 +-
>  arch/arm/include/asm/arch-mx28/sys_proto.h    |   10 +-
>  drivers/gpio/mxs_gpio.c                       |   16 +-
>  drivers/usb/host/ehci-mxs.c                   |    8 +-
>  21 files changed, 507 insertions(+), 551 deletions(-)

For patch 1, 2 and 3, add:

Tested-by: Marek Vasut <marex@denx.de>
Acked-by: Marek Vasut <marex@denx.de>

[U-Boot] [PATCH 0/4 v5] i.MX28: Fix ref_cpu clock setup

[Robert at domain.unknown]

From: Robert Delien <robert@delien.nl>

This set of patches fixes ref_cpu clock setup.

Robert Delien (4):
  Renamed mx28_register to mx28_register_32 to prepare for
    mx28_register_8
  Introducing 8-bit wide register, mx28_register_8
  Fix erroneous 32-bit access to hw_clkctrl_frac0 and hw_clkctrl_frac1
    registers
  Preventing needless switching on and off PLL bypass mode, allowing
    allow single-stepping through the SPL

 arch/arm/cpu/arm926ejs/mx28/clock.c           |   74 +++-----
 arch/arm/cpu/arm926ejs/mx28/iomux.c           |    6 +-
 arch/arm/cpu/arm926ejs/mx28/mx28.c            |    6 +-
 arch/arm/cpu/arm926ejs/mx28/spl_mem_init.c    |   30 ++--
 arch/arm/cpu/arm926ejs/mx28/spl_power_init.c  |   24 ---
 arch/arm/include/asm/arch-mx28/regs-apbh.h    |  254 ++++++++++++------------
 arch/arm/include/asm/arch-mx28/regs-bch.h     |   42 ++--
 arch/arm/include/asm/arch-mx28/regs-clkctrl.h |   98 ++++------
 arch/arm/include/asm/arch-mx28/regs-common.h  |   28 ++-
 arch/arm/include/asm/arch-mx28/regs-gpmi.h    |   26 ++--
 arch/arm/include/asm/arch-mx28/regs-i2c.h     |   28 ++--
 arch/arm/include/asm/arch-mx28/regs-ocotp.h   |   86 ++++----
 arch/arm/include/asm/arch-mx28/regs-pinctrl.h |  168 ++++++++--------
 arch/arm/include/asm/arch-mx28/regs-power.h   |   28 ++--
 arch/arm/include/asm/arch-mx28/regs-rtc.h     |   28 ++--
 arch/arm/include/asm/arch-mx28/regs-ssp.h     |   40 ++--
 arch/arm/include/asm/arch-mx28/regs-timrot.h  |   38 ++--
 arch/arm/include/asm/arch-mx28/regs-usbphy.h  |   20 +-
 arch/arm/include/asm/arch-mx28/sys_proto.h    |   10 +-
 drivers/gpio/mxs_gpio.c                       |   16 +-
 drivers/usb/host/ehci-mxs.c                   |    8 +-
 21 files changed, 507 insertions(+), 551 deletions(-)

[U-Boot] [PATCH 0/4 v5] i.MX28: Fix ref_cpu clock setup

[Marek Vasut]

> From: Robert Delien <robert@delien.nl>

Why did you repost? Fix that "domain.unknown"

M

> 
> This set of patches fixes ref_cpu clock setup.
> 
> Robert Delien (4):
>   Renamed mx28_register to mx28_register_32 to prepare for
>     mx28_register_8
>   Introducing 8-bit wide register, mx28_register_8
>   Fix erroneous 32-bit access to hw_clkctrl_frac0 and hw_clkctrl_frac1
>     registers
>   Preventing needless switching on and off PLL bypass mode, allowing
>     allow single-stepping through the SPL
> 
>  arch/arm/cpu/arm926ejs/mx28/clock.c           |   74 +++-----
>  arch/arm/cpu/arm926ejs/mx28/iomux.c           |    6 +-
>  arch/arm/cpu/arm926ejs/mx28/mx28.c            |    6 +-
>  arch/arm/cpu/arm926ejs/mx28/spl_mem_init.c    |   30 ++--
>  arch/arm/cpu/arm926ejs/mx28/spl_power_init.c  |   24 ---
>  arch/arm/include/asm/arch-mx28/regs-apbh.h    |  254
> ++++++++++++------------ arch/arm/include/asm/arch-mx28/regs-bch.h     |  
> 42 ++--
>  arch/arm/include/asm/arch-mx28/regs-clkctrl.h |   98 ++++------
>  arch/arm/include/asm/arch-mx28/regs-common.h  |   28 ++-
>  arch/arm/include/asm/arch-mx28/regs-gpmi.h    |   26 ++--
>  arch/arm/include/asm/arch-mx28/regs-i2c.h     |   28 ++--
>  arch/arm/include/asm/arch-mx28/regs-ocotp.h   |   86 ++++----
>  arch/arm/include/asm/arch-mx28/regs-pinctrl.h |  168 ++++++++--------
>  arch/arm/include/asm/arch-mx28/regs-power.h   |   28 ++--
>  arch/arm/include/asm/arch-mx28/regs-rtc.h     |   28 ++--
>  arch/arm/include/asm/arch-mx28/regs-ssp.h     |   40 ++--
>  arch/arm/include/asm/arch-mx28/regs-timrot.h  |   38 ++--
>  arch/arm/include/asm/arch-mx28/regs-usbphy.h  |   20 +-
>  arch/arm/include/asm/arch-mx28/sys_proto.h    |   10 +-
>  drivers/gpio/mxs_gpio.c                       |   16 +-
>  drivers/usb/host/ehci-mxs.c                   |    8 +-
>  21 files changed, 507 insertions(+), 551 deletions(-)

[U-Boot] [PATCH 0/4 v5] i.MX28: Fix ref_cpu clock setup

[Robert Deliën]

> Why did you repost?

I reposted with your ack in 1 to 3. Still they don't seem to show up in
the mailing list.

> Fix that "domain.unknown"

I can't. It's Agilent's smpt server's way to tell it's not happy with
relaying messages from my email address.

[U-Boot] [PATCH 0/4 v5] i.MX28: Fix ref_cpu clock setup

[Marek Vasut]

> > Why did you repost?
> 
> I reposted with your ack in 1 to 3. Still they don't seem to show up in
> the mailing list.

Patchwork handles that.
> 
> > Fix that "domain.unknown"
> 
> I can't. It's Agilent's smpt server's way to tell it's not happy with
> relaying messages from my email address.

Sure you can ... 

$ cat .gitconfig 
[user]
        name = Us Er
        email = user at ma.il

Done

[U-Boot] [PATCH 0/4 v5] i.MX28: Fix ref_cpu clock setup

[Wolfgang Denk]

Dear =?iso-8859-1?Q?Robert_Deli=EBn?=,

In message <6EA3E0BCC03CC34B89B01BD57ECBC718F829B4@POBOX.postoffice.danego.net> you wrote:
> > Why did you repost?
> 
> I reposted with your ack in 1 to 3. Still they don't seem to show up in
> the mailing list.

Never do this.  ACKs and such are tracked in patchwork.

And _if_ you repost, then play by the rules and add a changelog.

> > Fix that "domain.unknown"
> 
> I can't. It's Agilent's smpt server's way to tell it's not happy with
> relaying messages from my email address.

Then use a better relay.  Please fix it, it is a PITA not being able
to use "reply".

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
panic: kernel trap (ignored)

[U-Boot] [PATCH 0/4 v5] i.MX28: Fix ref_cpu clock setup

[Robert Deliën]

> Sure you can ...
> 
> $ cat .gitconfig
> [user]
>         name = Us Er
>         email = user at ma.il
> 
> Done

Thanks of the hint, but I configured that some time ago already (in ~/.gitconfig).
Git even confirms:
$ git config -l
user.name=Rxbert Dxlien
user.email=rxbert at dxlien.nl
color.diff=auto
color.status=auto
color.branch=auto
core.repositoryformatversion=0
core.filemode=true
core.bare=false
core.logallrefupdates=true
remote.origin.fetch=+refs/heads/*:refs/remotes/origin/*
remote.origin.url=git://git.denx.de/u-boot-imx.git
branch.master.remote=origin
branch.master.merge=refs/heads/master

But still no dice.

[U-Boot] [PATCH 0/4 v5] i.MX28: Fix ref_cpu clock setup

[Robert Deliën]

> Never do this.  ACKs and such are tracked in patchwork.

It's a hard to satsify everybody. I added the ack and and test
per Marek's request, and reposted.

> And _if_ you repost, then play by the rules and add a changelog.

>Then use a better relay.  Please fix it, it is a PITA not being able
> to use "reply".

That I can imagine.
It seems that git send-email doesn't handle --from"Name Domain
<name@domain.tld>" properly, so that's fixed now.

[U-Boot] [PATCH 0/4 v5] i.MX28: Fix ref_cpu clock setup

[Wolfgang Denk]

Dear Rxbert,

In message <6EA3E0BCC03CC34B89B01BD57ECBC718F82A89@POBOX.postoffice.danego.net> you wrote:
>
> Git even confirms:
> $ git config -l
> user.name=Rxbert Dxlien
> user.email=rxbert at dxlien.nl

And is this information correct?


Please STOP posting with non-existent mail addresses
(Robert at domain.unknown, Delien at domain.unknown) on the Cc: list.
Fix this, or I will block such messages.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Life would be so much easier if everyone read the manual.

[U-Boot] [PATCH 0/4 v5] i.MX28: Fix ref_cpu clock setup

[Fabio Estevam]

Robert,

On Wed, Feb 15, 2012 at 11:29 AM, Robert Deli?n <robert@delien.nl> wrote:

> Thanks of the hint, but I configured that some time ago already (in ~/.gitconfig).

If you have trouble to setup the gitconfig on your company network,
maybe you can use a gmail account.

cat .gitconfig
[user]
	name = User Name
	email = username at gmail.com
[sendemail]
	smtpserver = smtp.gmail.com
	smtpserverport = 587
	smtpencryption = tls
	smtpuser = username at gmail.com

You can then use "git send-email" without issues.

Regards,

Fabio Estevam

[U-Boot] [PATCH 0/4 v5] i.MX28: Fix ref_cpu clock setup

[Albert ARIBAUD]

Hi Robert,

Le 15/02/2012 11:29, Robert at domain.unknown a ?crit :
> From: Robert Delien<robert@delien.nl>
>
> This set of patches fixes ref_cpu clock setup.
>
> Robert Delien (4):
>    Renamed mx28_register to mx28_register_32 to prepare for
>      mx28_register_8
>    Introducing 8-bit wide register, mx28_register_8
>    Fix erroneous 32-bit access to hw_clkctrl_frac0 and hw_clkctrl_frac1
>      registers
>    Preventing needless switching on and off PLL bypass mode, allowing
>      allow single-stepping through the SPL
P
I don't see this V5 on patchwork. Please a V6 with up-to-date Tested-By 
/ Acked-By etc -- and of course make sure the e-mail address stays correct.

Besides, this touches i.MX, so I think Stefano should be at least Cc:

Amicalement,
-- 
Albert.

[U-Boot] [PATCH 0/4 v5] i.MX28: Fix ref_cpu clock setup

[Stefano Babic]

On 19/02/2012 10:23, Albert ARIBAUD wrote:
> Hi Robert,
> 
> Le 15/02/2012 11:29, Robert at domain.unknown a ?crit :
>> From: Robert Delien<robert@delien.nl>
>>
>> This set of patches fixes ref_cpu clock setup.
>>
>> Robert Delien (4):
>>    Renamed mx28_register to mx28_register_32 to prepare for
>>      mx28_register_8
>>    Introducing 8-bit wide register, mx28_register_8
>>    Fix erroneous 32-bit access to hw_clkctrl_frac0 and hw_clkctrl_frac1
>>      registers
>>    Preventing needless switching on and off PLL bypass mode, allowing
>>      allow single-stepping through the SPL
> P
> I don't see this V5 on patchwork. Please a V6 with up-to-date Tested-By
> / Acked-By etc -- and of course make sure the e-mail address stays correct.
> 
> Besides, this touches i.MX, so I think Stefano should be at least Cc:

Right - Robert, I miss also which is the state of the current patches -
is there still an issue that avoid boards to boot ?

Stefano


-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

[U-Boot] [PATCH 0/4 v5] i.MX28: Fix ref_cpu clock setup

[Marek Vasut]

> On 19/02/2012 10:23, Albert ARIBAUD wrote:
> > Hi Robert,
> > 
> > Le 15/02/2012 11:29, Robert at domain.unknown a ?crit :
> >> From: Robert Delien<robert@delien.nl>
> >> 
> >> This set of patches fixes ref_cpu clock setup.
> >> 
> >> Robert Delien (4):
> >>    Renamed mx28_register to mx28_register_32 to prepare for
> >>    
> >>      mx28_register_8
> >>    
> >>    Introducing 8-bit wide register, mx28_register_8
> >>    Fix erroneous 32-bit access to hw_clkctrl_frac0 and hw_clkctrl_frac1
> >>    
> >>      registers
> >>    
> >>    Preventing needless switching on and off PLL bypass mode, allowing
> >>    
> >>      allow single-stepping through the SPL
> > 
> > P
> > I don't see this V5 on patchwork. Please a V6 with up-to-date Tested-By
> > / Acked-By etc -- and of course make sure the e-mail address stays
> > correct.
> 
> > Besides, this touches i.MX, so I think Stefano should be at least Cc:
> Right - Robert, I miss also which is the state of the current patches -
> is there still an issue that avoid boards to boot ?

Yea ... that issue is fixed. I acked patches 1,2,3 ... I'm still unsure about 
patch 4.

M
> 
> Stefano

[U-Boot] [PATCH 0/4 v5] i.MX28: Fix ref_cpu clock setup

[Albert ARIBAUD]

Le 20/02/2012 08:40, Marek Vasut a ?crit :
>> On 19/02/2012 10:23, Albert ARIBAUD wrote:
>>> Hi Robert,
>>>
>>> Le 15/02/2012 11:29, Robert at domain.unknown a ?crit :
>>>> From: Robert Delien<robert@delien.nl>
>>>>
>>>> This set of patches fixes ref_cpu clock setup.
>>>>
>>>> Robert Delien (4):
>>>>     Renamed mx28_register to mx28_register_32 to prepare for
>>>>
>>>>       mx28_register_8
>>>>
>>>>     Introducing 8-bit wide register, mx28_register_8
>>>>     Fix erroneous 32-bit access to hw_clkctrl_frac0 and hw_clkctrl_frac1
>>>>
>>>>       registers
>>>>
>>>>     Preventing needless switching on and off PLL bypass mode, allowing
>>>>
>>>>       allow single-stepping through the SPL
>>>
>>> P
>>> I don't see this V5 on patchwork. Please a V6 with up-to-date Tested-By
>>> / Acked-By etc -- and of course make sure the e-mail address stays
>>> correct.
>>
>>> Besides, this touches i.MX, so I think Stefano should be at least Cc:
>> Right - Robert, I miss also which is the state of the current patches -
>> is there still an issue that avoid boards to boot ?
>
> Yea ... that issue is fixed. I acked patches 1,2,3 ... I'm still unsure about
> patch 4.
>
> M
>>
>> Stefano

I had an offline e-mail exchange with Robert, the conclusion of which is 
that he will not follow up on the patch series and we should cancel it.

Amicalement,
-- 
Albert.

[U-Boot] [PATCH 0/4 v5] i.MX28: Fix ref_cpu clock setup

[Fabio Estevam]

Hi Stefano,

On Mon, Feb 20, 2012 at 5:40 AM, Marek Vasut <marek.vasut@gmail.com> wrote:

> Yea ... that issue is fixed. I acked patches 1,2,3 ... I'm still unsure about
> patch 4.

Can patches 1,2,3 be applied? They fix the kernel reset issue.

Thanks,

Fabio Estevam

[U-Boot] [PATCH 0/4 v5] i.MX28: Fix ref_cpu clock setup

[Marek Vasut]

> Hi Stefano,
> 
> On Mon, Feb 20, 2012 at 5:40 AM, Marek Vasut <marek.vasut@gmail.com> wrote:
> > Yea ... that issue is fixed. I acked patches 1,2,3 ... I'm still unsure
> > about patch 4.
> 
> Can patches 1,2,3 be applied? They fix the kernel reset issue.
> 
> Thanks,
> 
> Fabio Estevam

I'll apply and retest what's suitable tomorrow. Then I'll submit pullrq to 
stefano. We already decided on that.

M