public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 15/17] power: twl6035: add palmas PMIC support
Date: Mon, 20 Feb 2012 10:49:42 -0700	[thread overview]
Message-ID: <20120220174942.GC20889@bill-the-cat> (raw)
In-Reply-To: <1329480333-18353-16-git-send-email-r.sricharan@ti.com>

On Fri, Feb 17, 2012 at 05:35:31PM +0530, R Sricharan wrote:

> From: Balaji T K <balajitk@ti.com>
> 
> palmas/TWL6035 is power IC for omap5 evm boards
> 
> Signed-off-by: Balaji T K <balajitk@ti.com>
[snip]
> +++ b/drivers/power/twl6035.c
[snip]
> +#ifdef CONFIG_TWL6035_POWER

Don't need to do that since we only link this file when that is set.

> +/* Functions to read and write from TWL6030 */
> +int twl6035_i2c_write_u8(u8 chip_no, u8 val, u8 reg)
> +{
> +	return i2c_write(chip_no, reg, 1, &val, 1);
> +}
> +
> +int twl6035_i2c_read_u8(u8 chip_no, u8 *val, u8 reg)
> +{
> +	return i2c_read(chip_no, reg, 1, val, 1);
> +}

Used, exported, OK.

> +/* To align with i2c mw/mr address, reg, val command syntax */
> +static inline int palmas_write_u8(u8 chip_no, u8 reg, u8 val)
> +{
> +	return i2c_write(chip_no, reg, 1, &val, 1);
> +}
> +
> +static inline int palmas_read_u8(u8 chip_no, u8 reg, u8 *val)
> +{
> +	return i2c_read(chip_no, reg, 1, val, 1);
> +}

Unused and static so this must have warned.  To be clear, I expect the
patch series to add no more warnings for omap5_evm.  Thanks!

-- 
Tom

  reply	other threads:[~2012-02-20 17:49 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-17 12:05 [U-Boot] [PATCH 00/17] OMAP5: Add the Changes required for OMAP5 ES1.0 silicon R Sricharan
2012-02-17 12:05 ` [U-Boot] [PATCH 01/17] OMAP5: clocks: Change clock settings as required for " R Sricharan
2012-02-17 12:05 ` [U-Boot] [PATCH 02/17] OMAP5: board: Add pinmux data for omap5_evm board R Sricharan
2012-02-17 12:05 ` [U-Boot] [PATCH 03/17] omap5: io: Configure the io settings for omap5430 sevm board R Sricharan
2012-02-17 12:05 ` [U-Boot] [PATCH 04/17] OMAP5: emif/ddr: Change emif settings as required for ES1.0 silicon R Sricharan
2012-02-20 17:36   ` Tom Rini
2012-02-21  7:53     ` R, Sricharan
2012-02-17 12:05 ` [U-Boot] [PATCH 05/17] OMAP5: palmas: Configure nominal opp vdd values R Sricharan
2012-02-17 12:05 ` [U-Boot] [PATCH 06/17] OMAP5: hwinit: Add the missing break statement R Sricharan
2012-02-17 12:05 ` [U-Boot] [PATCH 07/17] OMAP4/5: Make the silicon revision variable common R Sricharan
2012-02-17 12:05 ` [U-Boot] [PATCH 08/17] OMAP5: SRAM: Change the SRAM base address R Sricharan
2012-02-17 12:05 ` [U-Boot] [PATCH 09/17] OMAP4/5: Make the sysctrl structure common R Sricharan
2012-02-17 12:05 ` [U-Boot] [PATCH 10/17] OMAP4/5: device: Add support to get the device type R Sricharan
2012-02-17 12:05 ` [U-Boot] [PATCH 11/17] OMAP5: defconfig: Align the defconfig for 5430 ES1.0 R Sricharan
2012-02-20 17:45   ` Tom Rini
2012-02-21  7:46     ` R, Sricharan
2012-02-21 14:49       ` Tom Rini
2012-02-21 15:20         ` R, Sricharan
2012-02-17 12:05 ` [U-Boot] [PATCH 12/17] OMAP5: ddr: Change the ddr device name R Sricharan
2012-02-17 12:05 ` [U-Boot] [PATCH 13/17] OMAP4/5: emif: Correct the emif power mgt shadow register bit fields R Sricharan
2012-02-17 12:05 ` [U-Boot] [PATCH 14/17] arm: omap5: correct boot device mode7 for eMMC R Sricharan
2012-02-17 12:05 ` [U-Boot] [PATCH 15/17] power: twl6035: add palmas PMIC support R Sricharan
2012-02-20 17:49   ` Tom Rini [this message]
2012-02-21 10:58     ` R, Sricharan
2012-02-17 12:05 ` [U-Boot] [PATCH 16/17] omap5: pbias ldo9 turn on R Sricharan
2012-02-20 17:52   ` Tom Rini
2012-02-17 12:05 ` [U-Boot] [PATCH 17/17] mmc: omap5evm: Add eMMC saveenv support R Sricharan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120220174942.GC20889@bill-the-cat \
    --to=trini@ti.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox