From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Mon, 20 Feb 2012 13:07:46 -0700 Subject: [U-Boot] [PATCH 2/4] arm: add %function attribute to assembly functions In-Reply-To: <201202190215.31780.vapier@gentoo.org> References: <1328528248-20872-1-git-send-email-aneesh@ti.com> <1329314253-4596-3-git-send-email-aneesh@ti.com> <201202190215.31780.vapier@gentoo.org> Message-ID: <20120220200746.GA5787@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Sun, Feb 19, 2012 at 02:15:30AM -0500, Mike Frysinger wrote: > On Saturday 18 February 2012 17:03:59 Simon Glass wrote: > > On Wed, Feb 15, 2012 at 5:57 AM, Aneesh V wrote: > > > -.globl reset_cpu > > > +.type reset_cpu, %function > > > +.global reset_cpu > > > > Should we introduce a macro to deal with this rather than writing it > > out each time? EXPORT()? > > we have it already with the linux/linkage.h header :) Well, unless my tree is out of date (or stuff is in-flight) we don't have the full compliment here. We have for all and for bfin. That said, yes, we should grab at least the ARM version and make use of ENTRY/END_FUNC ala the kernel. I'm behind on my "convert __attribute__((...)) to __attr" series already or I'd say more :) -- Tom