From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 11/17] OMAP5: defconfig: Align the defconfig for 5430 ES1.0
Date: Tue, 21 Feb 2012 07:49:31 -0700 [thread overview]
Message-ID: <20120221144931.GC23487@bill-the-cat> (raw)
In-Reply-To: <CAJ7qFSfatKqxFcbZn-p_RcbMyH1oGcN9hcZoX4TpyztX1p6kyw@mail.gmail.com>
On Tue, Feb 21, 2012 at 01:16:58PM +0530, R, Sricharan wrote:
> Hi Tom,
>
> On Mon, Feb 20, 2012 at 11:15 PM, Tom Rini <trini@ti.com> wrote:
>
> > On Fri, Feb 17, 2012 at 05:35:27PM +0530, R Sricharan wrote:
> >
> > > Adding the nessecary changes for OMAP5430 ES1.0 silicon.
> > >
> > > Signed-off-by: R Sricharan <r.sricharan@ti.com>
> > [snip]
> > > +/* OPP SETTING */
> > > +#define OPP_NOM
> >
> > Where is this used?
> > Right. This is unused. Will remove this. We were having
> >
> OPP_LOW and OPP_HIGH settings in the clocks table, for internal testing.
> But that being eventually removed, this is not required.
>
>
> > [snip]
> > > /* Defines for SPL */
> > > #define CONFIG_SPL
> > > -#define CONFIG_SPL_TEXT_BASE 0x40304350
> > > -#define CONFIG_SPL_MAX_SIZE 0x1E000 /* 120K */
> > > +#define CONFIG_SPL_TEXT_BASE 0x40300350
> > > +#define CONFIG_SPL_MAX_SIZE 0x20000 /* 128K */
> > > #define CONFIG_SPL_STACK LOW_LEVEL_SRAM_STACK
> >
> > This is wrong, you have to account for stack within SPL_MAX_SIZE.
> >
> > To understand,
> So now, LOW_LEVEL_SRAM_STACK points to SRAM base + 128KB address (which
> is the SRAM size),
> pointed to by NON_SECURE_SRAM_END
> Should this be changed ?
> Also CONFIG_SYS_INIT_SP_ADDR should be adjusted. Will change this
So, the issue (see http://patchwork.ozlabs.org/patch/142211/ as I
believe omap4/5 are similar in method) is that both SPL text/data/rodata
and stack reside in SRAM. So we use CONFIG_SPL_MAX_SIZE as a way of
ensuring that at least some portion of SRAM will be available for
stack). You need to pick how much will be available for each part. For
example, on am335x we also have 128KB of SRAM but do an arbitrary split
at 46KB for SPL (since we haven't needed more than that). All you need
to do is pick SPL_MAX_SIZE less than 128KB. And prepare to write a
README.omap45 or so similar to the README.omap3 I wrote :)
--
Tom
next prev parent reply other threads:[~2012-02-21 14:49 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-17 12:05 [U-Boot] [PATCH 00/17] OMAP5: Add the Changes required for OMAP5 ES1.0 silicon R Sricharan
2012-02-17 12:05 ` [U-Boot] [PATCH 01/17] OMAP5: clocks: Change clock settings as required for " R Sricharan
2012-02-17 12:05 ` [U-Boot] [PATCH 02/17] OMAP5: board: Add pinmux data for omap5_evm board R Sricharan
2012-02-17 12:05 ` [U-Boot] [PATCH 03/17] omap5: io: Configure the io settings for omap5430 sevm board R Sricharan
2012-02-17 12:05 ` [U-Boot] [PATCH 04/17] OMAP5: emif/ddr: Change emif settings as required for ES1.0 silicon R Sricharan
2012-02-20 17:36 ` Tom Rini
2012-02-21 7:53 ` R, Sricharan
2012-02-17 12:05 ` [U-Boot] [PATCH 05/17] OMAP5: palmas: Configure nominal opp vdd values R Sricharan
2012-02-17 12:05 ` [U-Boot] [PATCH 06/17] OMAP5: hwinit: Add the missing break statement R Sricharan
2012-02-17 12:05 ` [U-Boot] [PATCH 07/17] OMAP4/5: Make the silicon revision variable common R Sricharan
2012-02-17 12:05 ` [U-Boot] [PATCH 08/17] OMAP5: SRAM: Change the SRAM base address R Sricharan
2012-02-17 12:05 ` [U-Boot] [PATCH 09/17] OMAP4/5: Make the sysctrl structure common R Sricharan
2012-02-17 12:05 ` [U-Boot] [PATCH 10/17] OMAP4/5: device: Add support to get the device type R Sricharan
2012-02-17 12:05 ` [U-Boot] [PATCH 11/17] OMAP5: defconfig: Align the defconfig for 5430 ES1.0 R Sricharan
2012-02-20 17:45 ` Tom Rini
2012-02-21 7:46 ` R, Sricharan
2012-02-21 14:49 ` Tom Rini [this message]
2012-02-21 15:20 ` R, Sricharan
2012-02-17 12:05 ` [U-Boot] [PATCH 12/17] OMAP5: ddr: Change the ddr device name R Sricharan
2012-02-17 12:05 ` [U-Boot] [PATCH 13/17] OMAP4/5: emif: Correct the emif power mgt shadow register bit fields R Sricharan
2012-02-17 12:05 ` [U-Boot] [PATCH 14/17] arm: omap5: correct boot device mode7 for eMMC R Sricharan
2012-02-17 12:05 ` [U-Boot] [PATCH 15/17] power: twl6035: add palmas PMIC support R Sricharan
2012-02-20 17:49 ` Tom Rini
2012-02-21 10:58 ` R, Sricharan
2012-02-17 12:05 ` [U-Boot] [PATCH 16/17] omap5: pbias ldo9 turn on R Sricharan
2012-02-20 17:52 ` Tom Rini
2012-02-17 12:05 ` [U-Boot] [PATCH 17/17] mmc: omap5evm: Add eMMC saveenv support R Sricharan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120221144931.GC23487@bill-the-cat \
--to=trini@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox