From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Thu, 23 Feb 2012 08:20:24 -0700 Subject: [U-Boot] [PATCH 2/2] usb: Add quirk "USB_QUIRK_STRING_FETCH_255" In-Reply-To: <1330007126-16481-2-git-send-email-puneets@nvidia.com> References: <201202171224.00086.vapier@gentoo.org> <1330007126-16481-2-git-send-email-puneets@nvidia.com> Message-ID: <20120223152024.GA29633@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Thu, Feb 23, 2012 at 07:55:26PM +0530, Puneet Saxena wrote: > Add a quirk "USB_QUIRK_STRING_FETCH_255", borrowed from Linux > kernel to fetch string using descriptor length then fetch actual bytes > returned in descriptor buffer. > > Signed-off-by: Puneet Saxena I think this is too literal a borrowing. In the kernel we don't use CONFIG_... since we have dev->quirks and check that for this flag. But here IMHO we should just do CONFIG_USB_QURIK_... -- Tom