* [U-Boot] [PATCH] USB: fix USB keyboard polling parameter
@ 2012-01-09 18:35 Vincent Palatin
2012-01-09 20:46 ` Marek Vasut
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Vincent Palatin @ 2012-01-09 18:35 UTC (permalink / raw)
To: u-boot
When doing a "GET_REPORT" request on the keyboard control endpoint,
the report ID should 0 (ie report ID not used) rather than 1
as reports are not used in boot mode.
Signed-off-by: Vincent Palatin <vpalatin@chromium.org>
---
common/usb_kbd.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/common/usb_kbd.c b/common/usb_kbd.c
index 75107c9..aaf7d6f 100644
--- a/common/usb_kbd.c
+++ b/common/usb_kbd.c
@@ -320,7 +320,7 @@ static inline void usb_kbd_poll_for_event(struct usb_device *dev)
struct usb_kbd_pdata *data = dev->privptr;
iface = &dev->config.if_desc[0];
usb_get_report(dev, iface->desc.bInterfaceNumber,
- 1, 1, data->new, sizeof(data->new));
+ 1, 0, data->new, sizeof(data->new));
if (memcmp(data->old, data->new, sizeof(data->new)))
usb_kbd_irq_worker(dev);
#endif
--
1.7.3.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] USB: fix USB keyboard polling parameter
2012-01-09 18:35 [U-Boot] [PATCH] USB: fix USB keyboard polling parameter Vincent Palatin
@ 2012-01-09 20:46 ` Marek Vasut
2012-01-09 20:50 ` Vincent Palatin
2012-01-15 19:49 ` Remy Bohmer
2012-02-26 23:10 ` Marek Vasut
2 siblings, 1 reply; 6+ messages in thread
From: Marek Vasut @ 2012-01-09 20:46 UTC (permalink / raw)
To: u-boot
> When doing a "GET_REPORT" request on the keyboard control endpoint,
> the report ID should 0 (ie report ID not used) rather than 1
> as reports are not used in boot mode.
>
> Signed-off-by: Vincent Palatin <vpalatin@chromium.org>
> ---
> common/usb_kbd.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/common/usb_kbd.c b/common/usb_kbd.c
> index 75107c9..aaf7d6f 100644
> --- a/common/usb_kbd.c
> +++ b/common/usb_kbd.c
> @@ -320,7 +320,7 @@ static inline void usb_kbd_poll_for_event(struct
> usb_device *dev) struct usb_kbd_pdata *data = dev->privptr;
> iface = &dev->config.if_desc[0];
> usb_get_report(dev, iface->desc.bInterfaceNumber,
> - 1, 1, data->new, sizeof(data->new));
> + 1, 0, data->new, sizeof(data->new));
> if (memcmp(data->old, data->new, sizeof(data->new)))
> usb_kbd_irq_worker(dev);
> #endif
Good, did you test this?
M
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] USB: fix USB keyboard polling parameter
2012-01-09 20:46 ` Marek Vasut
@ 2012-01-09 20:50 ` Vincent Palatin
2012-01-09 20:53 ` Marek Vasut
0 siblings, 1 reply; 6+ messages in thread
From: Vincent Palatin @ 2012-01-09 20:50 UTC (permalink / raw)
To: u-boot
On Mon, Jan 9, 2012 at 12:46, Marek Vasut <marek.vasut@gmail.com> wrote:
>> When doing a "GET_REPORT" request on the keyboard control endpoint,
>> the report ID should 0 (ie report ID not used) rather than 1
>> as reports are not used in boot mode.
>>
>> Signed-off-by: Vincent Palatin <vpalatin@chromium.org>
>> ---
>> ?common/usb_kbd.c | ? ?2 +-
>> ?1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/common/usb_kbd.c b/common/usb_kbd.c
>> index 75107c9..aaf7d6f 100644
>> --- a/common/usb_kbd.c
>> +++ b/common/usb_kbd.c
>> @@ -320,7 +320,7 @@ static inline void usb_kbd_poll_for_event(struct
>> usb_device *dev) struct usb_kbd_pdata *data = dev->privptr;
>> ? ? ? iface = &dev->config.if_desc[0];
>> ? ? ? usb_get_report(dev, iface->desc.bInterfaceNumber,
>> - ? ? ? ? ? ? ? ? ? ? 1, 1, data->new, sizeof(data->new));
>> + ? ? ? ? ? ? ? ? ? ? 1, 0, data->new, sizeof(data->new));
>> ? ? ? if (memcmp(data->old, data->new, sizeof(data->new)))
>> ? ? ? ? ? ? ? usb_kbd_irq_worker(dev);
>> ?#endif
>
> Good, did you test this?
Yes, on about a dozen different keyboards :
most don't care, a couple used to be confused and are now working.
--
Vincent
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] USB: fix USB keyboard polling parameter
2012-01-09 20:50 ` Vincent Palatin
@ 2012-01-09 20:53 ` Marek Vasut
0 siblings, 0 replies; 6+ messages in thread
From: Marek Vasut @ 2012-01-09 20:53 UTC (permalink / raw)
To: u-boot
> On Mon, Jan 9, 2012 at 12:46, Marek Vasut <marek.vasut@gmail.com> wrote:
> >> When doing a "GET_REPORT" request on the keyboard control endpoint,
> >> the report ID should 0 (ie report ID not used) rather than 1
> >> as reports are not used in boot mode.
> >>
> >> Signed-off-by: Vincent Palatin <vpalatin@chromium.org>
> >> ---
> >> common/usb_kbd.c | 2 +-
> >> 1 files changed, 1 insertions(+), 1 deletions(-)
> >>
> >> diff --git a/common/usb_kbd.c b/common/usb_kbd.c
> >> index 75107c9..aaf7d6f 100644
> >> --- a/common/usb_kbd.c
> >> +++ b/common/usb_kbd.c
> >> @@ -320,7 +320,7 @@ static inline void usb_kbd_poll_for_event(struct
> >> usb_device *dev) struct usb_kbd_pdata *data = dev->privptr;
> >> iface = &dev->config.if_desc[0];
> >> usb_get_report(dev, iface->desc.bInterfaceNumber,
> >> - 1, 1, data->new, sizeof(data->new));
> >> + 1, 0, data->new, sizeof(data->new));
> >> if (memcmp(data->old, data->new, sizeof(data->new)))
> >> usb_kbd_irq_worker(dev);
> >> #endif
> >
> > Good, did you test this?
>
> Yes, on about a dozen different keyboards :
> most don't care, a couple used to be confused and are now working.
Awesome :-) I'll test this on mine and Ack it then.
btw. why do you even need this? Do you have some weird hardware ?
M
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] USB: fix USB keyboard polling parameter
2012-01-09 18:35 [U-Boot] [PATCH] USB: fix USB keyboard polling parameter Vincent Palatin
2012-01-09 20:46 ` Marek Vasut
@ 2012-01-15 19:49 ` Remy Bohmer
2012-02-26 23:10 ` Marek Vasut
2 siblings, 0 replies; 6+ messages in thread
From: Remy Bohmer @ 2012-01-15 19:49 UTC (permalink / raw)
To: u-boot
Hi,
2012/1/9 Vincent Palatin <vpalatin@chromium.org>:
> When doing a "GET_REPORT" request on the keyboard control endpoint,
> the report ID should 0 (ie report ID not used) rather than 1
> as reports are not used in boot mode.
>
> Signed-off-by: Vincent Palatin <vpalatin@chromium.org>
> ---
Applied to u-boot-usb. Thanks.
Kind regards,
Remy
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] USB: fix USB keyboard polling parameter
2012-01-09 18:35 [U-Boot] [PATCH] USB: fix USB keyboard polling parameter Vincent Palatin
2012-01-09 20:46 ` Marek Vasut
2012-01-15 19:49 ` Remy Bohmer
@ 2012-02-26 23:10 ` Marek Vasut
2 siblings, 0 replies; 6+ messages in thread
From: Marek Vasut @ 2012-02-26 23:10 UTC (permalink / raw)
To: u-boot
> When doing a "GET_REPORT" request on the keyboard control endpoint,
> the report ID should 0 (ie report ID not used) rather than 1
> as reports are not used in boot mode.
>
> Signed-off-by: Vincent Palatin <vpalatin@chromium.org>
> ---
> common/usb_kbd.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/common/usb_kbd.c b/common/usb_kbd.c
> index 75107c9..aaf7d6f 100644
> --- a/common/usb_kbd.c
> +++ b/common/usb_kbd.c
> @@ -320,7 +320,7 @@ static inline void usb_kbd_poll_for_event(struct
> usb_device *dev) struct usb_kbd_pdata *data = dev->privptr;
> iface = &dev->config.if_desc[0];
> usb_get_report(dev, iface->desc.bInterfaceNumber,
> - 1, 1, data->new, sizeof(data->new));
> + 1, 0, data->new, sizeof(data->new));
> if (memcmp(data->old, data->new, sizeof(data->new)))
> usb_kbd_irq_worker(dev);
> #endif
Hi,
what's the status of this patch/patchset?
Thanks
M
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-02-26 23:10 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-09 18:35 [U-Boot] [PATCH] USB: fix USB keyboard polling parameter Vincent Palatin
2012-01-09 20:46 ` Marek Vasut
2012-01-09 20:50 ` Vincent Palatin
2012-01-09 20:53 ` Marek Vasut
2012-01-15 19:49 ` Remy Bohmer
2012-02-26 23:10 ` Marek Vasut
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox