From: Sughosh Ganu <urwithsughosh@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v4 07/13] davinci: Use correct #ifdef around gdata/bdata
Date: Mon, 27 Feb 2012 15:46:13 +0530 [thread overview]
Message-ID: <20120227101613.GA2183@Hardy> (raw)
In-Reply-To: <CAPnjgZ1mYGMjNQKw-=jV6R8VpV8vLVo9Y6=roUJd-TwuOi-WZw@mail.gmail.com>
hi Simon,
On Sun Feb 26, 2012 at 09:56:37AM -0800, Simon Glass wrote:
> Hi Sughosh,
>
> On Thu, Feb 23, 2012 at 9:25 AM, Sughosh Ganu <urwithsughosh@gmail.com> wrote:
> > hi Simon,
> >
> > On Mon Feb 20, 2012 at 05:32:49PM -0800, Simon Glass wrote:
> >> This fixes the following warnings in an SPL build when libcommon is
> >> in use:
> >>
> >> spl.c:37: warning: 'gdata' defined but not used
> >> spl.c:38: warning: 'bdata' defined but not used
> >>
> >> Signed-off-by: Simon Glass <sjg@chromium.org>
> >> ---
> >> Changes in v4:
> >> - Add new patch to fix davinci build warnings
> >>
> >> ?arch/arm/cpu/arm926ejs/davinci/spl.c | ? ?2 ++
> >> ?1 files changed, 2 insertions(+), 0 deletions(-)
> >>
> >> diff --git a/arch/arm/cpu/arm926ejs/davinci/spl.c b/arch/arm/cpu/arm926ejs/davinci/spl.c
> >> index b1eff26..2861907 100644
> >> --- a/arch/arm/cpu/arm926ejs/davinci/spl.c
> >> +++ b/arch/arm/cpu/arm926ejs/davinci/spl.c
> >> @@ -32,10 +32,12 @@
> >>
> >> ?#ifdef CONFIG_SPL_LIBCOMMON_SUPPORT
> >>
> >> +#ifdef CONFIG_SPL_SPI_LOAD
> >> ?DECLARE_GLOBAL_DATA_PTR;
> >> ?/* Define global data structure pointer to it*/
> >> ?static gd_t gdata __attribute__ ((section(".data")));
> >> ?static bd_t bdata __attribute__ ((section(".data")));
> >> +#endif
> >
> > ?Can you specify which boards you get this warning for. With your
> > ?patch to add libcommon to hawkboard's spl image, this is now also
> > ?needed for hawkboard which uses CONFIG_SPL_NAND_LOAD.
>
> Perhaps it is any davinci board, with SPI? I don't have any of these -
> I was just fixing what I thought was a minor #ifdef bug in the code.
I checked the configs for all the davinci boards, and cam_enc_4xx,
da850* and hawkboard use spl. Out of these the da850* use a spi
flash, while cam_enc_4xx and hawkboard both use a nand. So we should
not be using the CONFIG_SPL_SPI_LOAD check to exclude the gdata and
bdata objects -- these are now needed after adding the libcommon
support to the hawkboard.
Also, the cam_enc_4xx board which uses a spl does not have
CONFIG_SPL_LIBCOMMON_SUPPORT and CONFIG_SPL_LIBGENERIC_SUPPORT
defined and this patchset does not add these defines for the
board. Was adding these defines for the board missed out. If so,
then this patch would no longer be needed.
-sughosh
next prev parent reply other threads:[~2012-02-27 10:16 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-21 1:32 [U-Boot] [PATCH v4 0/13] Introduce generic relocation feature Simon Glass
2012-02-21 1:32 ` [U-Boot] [PATCH v4 01/13] Define CONFIG_SYS_SKIP_RELOC for all archs Simon Glass
2012-03-06 5:04 ` Mike Frysinger
2012-03-06 6:27 ` Simon Glass
2012-02-21 1:32 ` [U-Boot] [PATCH v4 02/13] Add generic relocation feature Simon Glass
2012-02-21 19:36 ` Albert ARIBAUD
2012-02-21 20:03 ` Simon Glass
2012-02-21 1:32 ` [U-Boot] [PATCH v4 03/13] arm: Export and promote relocation symbols Simon Glass
2012-02-21 1:32 ` [U-Boot] [PATCH v4 04/13] arm: Add start_call_board_init_r() to each start.S Simon Glass
2012-02-21 19:32 ` Albert ARIBAUD
2012-02-21 20:02 ` Simon Glass
2012-02-23 13:07 ` Simon Glass
2012-02-21 1:32 ` [U-Boot] [PATCH v4 05/13] Move memcpy(), memset() into new lib/membasic.c Simon Glass
2012-03-06 5:05 ` Mike Frysinger
2012-03-06 6:34 ` Simon Glass
2012-03-06 16:20 ` Mike Frysinger
2012-03-07 5:43 ` Simon Glass
2012-03-07 5:50 ` Graeme Russ
2012-03-07 17:48 ` Simon Glass
2012-03-11 7:35 ` Mike Frysinger
2012-02-21 1:32 ` [U-Boot] [PATCH v4 06/13] arm: Add explicit __image_copy_end symbol for ARM926EJ-S Simon Glass
2012-02-21 1:32 ` [U-Boot] [PATCH v4 07/13] davinci: Use correct #ifdef around gdata/bdata Simon Glass
2012-02-21 15:24 ` Tom Rini
2012-02-23 17:25 ` Sughosh Ganu
2012-02-26 17:56 ` Simon Glass
2012-02-27 10:16 ` Sughosh Ganu [this message]
2012-02-27 10:39 ` Christian Riesch
2012-02-27 10:56 ` Sughosh Ganu
2012-02-27 11:37 ` Christian Riesch
2012-02-27 12:02 ` Sughosh Ganu
2012-02-28 21:55 ` Albert ARIBAUD
2012-02-28 22:03 ` Scott Wood
2012-03-03 20:22 ` Simon Glass
2012-03-03 20:29 ` Simon Glass
2012-02-21 1:32 ` [U-Boot] [PATCH v4 08/13] tx25: Modify to work with generic relocation Simon Glass
2012-02-21 1:32 ` [U-Boot] [PATCH v4 09/13] hawkboard: " Simon Glass
2012-02-21 15:25 ` Tom Rini
2012-02-23 8:43 ` Sughosh Ganu
2012-02-23 15:11 ` Sughosh Ganu
2012-02-26 18:09 ` Simon Glass
2012-02-21 1:32 ` [U-Boot] [PATCH v4 10/13] mx31pdk: " Simon Glass
2012-02-21 1:32 ` [U-Boot] [PATCH v4 11/13] smdk6400: " Simon Glass
2012-02-21 1:32 ` [U-Boot] [PATCH v4 12/13] arm: Move over to " Simon Glass
2012-02-21 1:32 ` [U-Boot] [PATCH v4 13/13] arm: Remove unused code in start.S Simon Glass
2012-02-21 19:40 ` [U-Boot] [PATCH v4 0/13] Introduce generic relocation feature Albert ARIBAUD
2012-02-21 20:07 ` Simon Glass
2012-02-21 20:10 ` Graeme Russ
2012-02-21 20:16 ` Simon Glass
[not found] ` <4F4D4511.6020708@aribaud.net>
2012-03-03 16:01 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120227101613.GA2183@Hardy \
--to=urwithsughosh@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox