[U-Boot] [PATCH v8] usb: align buffers at cacheline

Marek Vasut
2012-04-02T16:11:46Z

Dear Tom Warren,

> Marek, Puneet, et al.,
>
> > -----Original Message-----
> > From: Marek Vasut [mailto:marex at denx.de]
> > Sent: Monday, March 19, 2012 8:47 AM
> > To: Tom Warren
> > Cc: Puneet Saxena; Mike Frysinger; u-boot at lists.denx.de;
> > sjg at chromium.org; linux at bohmer.net; trini at ti.com;
> > albert.u.boot at aribaud.net
> > Subject: Re: [PATCH v8] usb: align buffers at cacheline
> >
> > Dear Tom Warren,
> >
> > > Marek,
> > >
> > > > -----Original Message-----
> > > > From: Marek Vasut [mailto:marek.vasut at gmail.com]
> > > > Sent: Monday, March 19, 2012 7:43 AM
> > > > To: Puneet Saxena
> > > > Cc: Mike Frysinger; u-boot at lists.denx.de; sjg at chromium.org;
> > > > linux at bohmer.net; trini at ti.com; Tom Warren
> > > > Subject: Re: [PATCH v8] usb: align buffers at cacheline
> > > >
> > > > Dear Puneet Saxena,
> > > >
> > > > > Hi Marek,
> > > > > I adapted my patch for git://git.denx.de/u-boot-usb.git master
> > > > > branch. As the build for target "Seaboard" is broken once I enable
> > > > > USB in Seaboard.h, I am unable to test my changes on "u-boot-usb".
> > > >
> > > > u-boot-usb is forked off the mainline u-boot.git ... tegra stuff
> > > > likely isn't pulled there. Simon, can you tell me when this is gonna
> > > > be
> >
> > there?
> >
> > > Simon's USB/fdt patch set will be pulled into -arm first, then -main,
> > > when he adapts the 'panic' putc patchset (implement pre-console putc
> > > for fdt
> > > warning) to meet with Wolfgang's approval. Once that's done (hopefully
> > > early this week), I can submit another pull request to finally get
> > > this series in.
> > >
> > > Simon - can we have an ETA?
> >
> > I'd love to see some ETA on u-boot-arm push from Albert Aribaud :-(
> > Albert, how're you doing ?
> >
> > Thanks!
>
> u-boot-tegra/master has the fdt/USB patches, and has been pulled into ARM
> master.
>
> We need the cacheline/buffer alignment patch now, to remove the volcanic
> spew whenever you do any USB commands.
>
> Can you guys (Puneet & Marek, and Mike/Simon if necessary) work together to
> get this in soon?

Ain't you gonna help us? I believe the patch is really close to be usable, it
just needs some easy debugging, won't you volunteer, it'd really help? :)

> Thanks,
>
> Tom
>
> > > Tom
> > >
> > > > > I would have to merge lots of changes from "denx-uboot-tegra" to
> > > > > make it working for "u-boot-usb.git" master branch.
> > > > > I can send the adapted patch if it's needed.
> > > >
> > > > The problem I see is that there are important USB patches in
> > > > mainline, though they are not in -tegra. So the approach I'd take if
> > > > I were you would be to rebase -tegra atop of mainline for yourself
> > > > and then apply your patch. Does that work for you?
> > > >
> > > > > Thanks,
> > > > > Puneet
> > > >
> > > > Thanks!
> > > >
> > > > Best regards,
> > > > Marek Vasut
> >
> > Best regards,
> > Marek Vasut