[U-Boot] [PATCH v4] usb: align buffers at cacheline

Wolfgang Denk
2012-03-02T16:45:15Z

In message <201203021659.21568.marex@denx.de> you wrote:
>
...
> > That's what I did in original patch where I am aligning it by adding the
> > line
> >
> > + /* Device Descriptor */
> > +#ifdef ARCH_DMA_MINALIGN
> > + struct usb_device_descriptor descriptor
> > + __attribute__((aligned(ARCH_DMA_MINALIGN)));
> > +#else
> > + struct usb_device_descriptor descriptor;
> > +#endif
> >
> > in usb.h Line:112
> >
> > > M
> >
> I see ...and I told you it's wrong? I must have misunderstood, I'm sorry about
> that. But if you actually do this, you can avoid memcpy, right?

And eventually wd can also avoid the #ifdef ? I guess the
__attribute__((aligned...)) would not hurt anything?

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Der Horizont vieler Menschen ist ein Kreis mit Radius Null --
und das nennen sie ihren Standpunkt.