From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] nios2: move gd and bd into BSS
Date: Thu, 1 Mar 2012 12:17:22 -0500 [thread overview]
Message-ID: <201203011217.24148.vapier@gentoo.org> (raw)
In-Reply-To: <1330585745-19431-1-git-send-email-thomas@wytron.com.tw>
On Thursday 01 March 2012 02:09:05 Thomas Chou wrote:
> --- a/arch/nios2/lib/board.c
> +++ b/arch/nios2/lib/board.c
>
> +gd_t gd_data;
> +bd_t bd_data;
mark both static
> --- a/include/configs/nios2-generic.h
> +++ b/include/configs/nios2-generic.h
>
> * MEMORY ORGANIZATION
> * -Monitor at top of sdram.
> * -The heap is placed below the monitor
> - * -Global data is placed below the heap.
> - * -The stack is placed below global data (&grows down).
> + * -The stack is placed below the heap (&grows down).
you've got a tab after ther "*" but none of the previous lines do ...
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120301/554f6ead/attachment.pgp>
next prev parent reply other threads:[~2012-03-01 17:17 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-20 23:24 [U-Boot] memory corruption on nios2 due to overlap of gbl data and malloc Alex Hornung
2012-02-28 22:29 ` Albert ARIBAUD
2012-02-28 22:39 ` Graeme Russ
2012-02-28 22:55 ` Albert ARIBAUD
2012-02-28 23:20 ` Graeme Russ
2012-02-28 23:24 ` Albert ARIBAUD
2012-02-28 23:32 ` Graeme Russ
2012-02-29 19:04 ` Mike Frysinger
2012-02-29 22:22 ` Graeme Russ
2012-02-29 22:29 ` Mike Frysinger
2012-02-29 22:41 ` Graeme Russ
2012-03-01 7:09 ` [U-Boot] [PATCH] nios2: move gd and bd into BSS Thomas Chou
2012-03-01 17:17 ` Mike Frysinger [this message]
2012-03-02 2:55 ` [U-Boot] [PATCH v2] " Thomas Chou
2012-03-02 3:22 ` Mike Frysinger
2012-03-01 21:57 ` [U-Boot] memory corruption on nios2 due to overlap of gbl data and malloc Albert ARIBAUD
2012-03-01 22:11 ` Graeme Russ
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201203011217.24148.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox