From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 4/7] i.MX28: Enable additional DRAM address bits
Date: Thu, 1 Mar 2012 19:34:54 +0100 [thread overview]
Message-ID: <201203011934.54714.marex@denx.de> (raw)
In-Reply-To: <CAOMZO5Bf0PvaVhJrTqQyPrixziVi9b00UWwB-M7P0TP2M=WLbw@mail.gmail.com>
> On Sun, Feb 26, 2012 at 7:15 PM, Marek Vasut <marex@denx.de> wrote:
> > Signed-off-by: Marek Vasut <marex@denx.de>
> > ---
> > arch/arm/cpu/arm926ejs/mx28/spl_mem_init.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
>
> Could you please elaborate a commit message for this?
>
> From what I could see this is changing from 0x0f02020a to 0x0f02010a,
> and it would be nice to have in the commit message an explanation of
> what this register is, what you are changing and why.
If I could get my hands on Office 2010 to open that stupid memory thing supplied
by freescale, I would. But since I can't ... basically, this is magic which
enables all fourteen address lines. From what I remember, the piece at 0xf << 8
says how many address bits are to be disabled and 0 is prohibited.
Since all of them should be enabled now, I don't consider it necessary to poke
into this anymore. Or does it break anything for you?
M
next prev parent reply other threads:[~2012-03-01 18:34 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-26 22:15 [U-Boot] [PATCH 0/7] Set of various i.MX28 patches Marek Vasut
2012-02-26 22:15 ` [U-Boot] [PATCH 1/7] M28: Fix LCD PINMUX Marek Vasut
2012-03-03 9:06 ` Stefano Babic
2012-02-26 22:15 ` [U-Boot] [PATCH 2/7] M28: Support for the old M28 SoM v1.0 Marek Vasut
2012-03-03 9:07 ` Stefano Babic
2012-02-26 22:15 ` [U-Boot] [PATCH 3/7] i.MX28: Reformat the DRAM memory configuration data Marek Vasut
2012-03-03 9:09 ` Stefano Babic
2012-02-26 22:15 ` [U-Boot] [PATCH 4/7] i.MX28: Enable additional DRAM address bits Marek Vasut
2012-03-01 15:22 ` Fabio Estevam
2012-03-01 18:34 ` Marek Vasut [this message]
2012-03-01 18:39 ` Fabio Estevam
2012-03-01 18:52 ` Marek Vasut
2012-03-03 10:21 ` Stefano Babic
2012-03-03 12:02 ` Marek Vasut
2012-03-09 13:39 ` Stefano Babic
2012-02-26 22:15 ` [U-Boot] [PATCH 5/7] Renamed mx28_register to mx28_register_32 to prepare for mx28_register_8 Marek Vasut
2012-03-03 9:13 ` Stefano Babic
2012-02-26 22:15 ` [U-Boot] [PATCH 6/7] Introducing 8-bit wide register, mx28_register_8 Marek Vasut
2012-03-03 9:14 ` Stefano Babic
2012-02-26 22:15 ` [U-Boot] [PATCH 7/7] Fix erroneous 32-bit access to hw_clkctrl_frac0 and hw_clkctrl_frac1 registers Marek Vasut
2012-03-03 9:16 ` Stefano Babic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201203011934.54714.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox