From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marex@denx.de>
Date: Fri, 2 Mar 2012 11:41:34 +0100
Subject: [U-Boot] [PATCH] Enable high speed support for USB device
	framework and usbtty
In-Reply-To: <4F5060A5.9060906@st.com>
References: <1330335353-32164-1-git-send-email-amit.virdi@st.com>
	<201202292224.17205.marex@denx.de> <4F5060A5.9060906@st.com>
Message-ID: <201203021141.34752.marex@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

> Hi Marek,
> 
> >>>> +#if defined(CONFIG_USBD_HS)
> >>>> +/**
> >>>> + * usbd_device_qualifier_descriptor
> >>>> + * @device: which device
> >>>> + * @port: which port
> >>>> + *
> >>>> + * Return the specified qualifier descriptor for the specified
> >>>> device. + */
> >>>> +struct usb_qualifier_descriptor *usbd_device_qualifier_descriptor(
> >>>> +		struct usb_device_instance *device, int port)
> >>> 
> >>> Make this static, but do you really need this function at all?
> >> 
> >> Well... usbd_device_qualifier_descriptor can't be static as the function
> >> is called from another file (ep0.c). However, since it is used only for
> >> EP0, it can be omitted for the time being keeping in mind we might need
> >> to define it in future (if the need arises). What do you think?
> > 
> > What do you mean. If this is called from ep0.c, it has to be exported and
> > that's how it is. On the other hand, if ep0.c already has access to the
> > "device", it can directly access the device_descriptor field, which is I
> > believe expressive enough.
> 
> Yes, ep0.c has direct access to the "device" field. I'll omit the
> usbd_device_qualifier_descriptor function in V2.
> 

Thank you :-)

M