From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 5/7] net/designware: Try configuring phy on each dw_eth_init
Date: Fri, 2 Mar 2012 13:38:38 -0500 [thread overview]
Message-ID: <201203021338.42692.vapier@gentoo.org> (raw)
In-Reply-To: <4F50B197.8020203@st.com>
On Friday 02 March 2012 06:40:07 Amit Virdi wrote:
> On 3/1/2012 12:41 AM, Mike Frysinger wrote:
> >> + u32 phy_configured;
> >>
> >> > +#define FALSE (0)
> >> > +#define TRUE (!FALSE)
> >
> > NAK: we already have "true" and "false" and the "bool" type. use those
> > instead.
>
> Are you sure Mike? I couldn't find in u-boot code "TRUE" and "FALSE"
> defined in any common header file.
i said "true" and "false", not "TRUE" and "FALSE"
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120302/8ff217d2/attachment.pgp>
next prev parent reply other threads:[~2012-03-02 18:38 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-29 10:37 [U-Boot] [PATCH 0/7] net/designware: Bug fixes Amit Virdi
2012-02-29 10:37 ` [U-Boot] [PATCH 1/7] net/designware: Fix to restore hw mac address Amit Virdi
2012-02-29 19:09 ` Mike Frysinger
2012-03-02 11:27 ` Amit Virdi
2012-02-29 10:37 ` [U-Boot] [PATCH 2/7] net/designware: Fix the max frame length size Amit Virdi
2012-02-29 10:37 ` [U-Boot] [PATCH 3/7] net/designware: Phy address fix Amit Virdi
2012-02-29 10:37 ` [U-Boot] [PATCH 4/7] net/designware: Consecutive writes must have delay Amit Virdi
2012-02-29 10:37 ` [U-Boot] [PATCH 5/7] net/designware: Try configuring phy on each dw_eth_init Amit Virdi
2012-02-29 19:11 ` Mike Frysinger
2012-03-02 11:40 ` Amit Virdi
2012-03-02 18:38 ` Mike Frysinger [this message]
2012-03-05 12:18 ` Amit Virdi
2012-03-05 19:05 ` Wolfgang Denk
2012-03-06 4:21 ` Amit Virdi
2012-02-29 10:37 ` [U-Boot] [PATCH 6/7] net/designware: Program phy registers when auto-negotiation is ON Amit Virdi
2012-02-29 10:37 ` [U-Boot] [PATCH 7/7] net/designware: Set ANAR to 0x1e1 Amit Virdi
2012-03-07 9:49 ` [U-Boot] [PATCH 0/7] net/designware: Bug fixes Amit Virdi
2012-03-07 9:55 ` Stefan Roese
2012-03-07 10:05 ` Amit Virdi
2012-03-07 12:15 ` Amit Virdi
2012-03-07 12:36 ` Wolfgang Denk
2012-03-07 16:10 ` Joe Hershberger
2012-03-08 10:55 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201203021338.42692.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox