From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] fs/fat alignment
Date: Sat, 3 Mar 2012 18:14:01 -0500 [thread overview]
Message-ID: <201203031814.02944.vapier@gentoo.org> (raw)
In-Reply-To: <1330812338-25820-1-git-send-email-eric.nelson@boundarydevices.com>
On Saturday 03 March 2012 17:05:37 Eric Nelson wrote:
> Note that checkpatch fails on this patch with the following warning,
> but I'm not sure how to resolve it.
>
> Nothing else in the U-Boot code base seems to use __align() although
> it's defined in include/linux/compiler-gcc.h.
>
> #46: FILE: fs/fat/fat.c:432:
> +__attribute__ ((__aligned__ (ARCH_DMA_MINALIGN)))
>
> WARNING: __aligned(size) is preferred over __attribute__((aligned(size)))
> #46: FILE: fs/fat/fat.c:432:
> +__attribute__ ((__aligned__ (ARCH_DMA_MINALIGN)))
>
> total: 0 errors, 2 warnings, 47 lines checked
it's easy enough to include linux/compiler.h and use __align()
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120303/58259b4e/attachment.pgp>
next prev parent reply other threads:[~2012-03-03 23:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-03 22:05 [U-Boot] fs/fat alignment Eric Nelson
2012-03-03 22:05 ` [U-Boot] fs/fat: align disk buffers on cache line to enable DMA and cache Eric Nelson
2012-03-03 23:14 ` Mike Frysinger
2012-03-03 23:14 ` Mike Frysinger [this message]
2012-03-03 23:50 ` [U-Boot] fs/fat alignment Wolfgang Denk
2012-03-04 0:54 ` Eric Nelson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201203031814.02944.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox