* [U-Boot] [PATCH] post/Makefile: Only build FP post tests if enabled via CONFIG_SYS_POST_FPU
@ 2012-01-12 19:30 Kumar Gala
2012-01-13 19:42 ` Wolfgang Denk
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Kumar Gala @ 2012-01-12 19:30 UTC (permalink / raw)
To: u-boot
Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
---
post/Makefile | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/post/Makefile b/post/Makefile
index 200e2f1..55b7d21 100644
--- a/post/Makefile
+++ b/post/Makefile
@@ -32,7 +32,7 @@ COBJS-$(CONFIG_POST_STD_LIST) += tests.o
SPLIB-$(CONFIG_HAS_POST) = drivers/libpostdrivers.o
SPLIB-$(CONFIG_HAS_POST) += $(shell if [ -d lib_$(ARCH) ]; then echo \
"lib_$(ARCH)/libpost$(ARCH).o"; fi)
-SPLIB-$(CONFIG_HAS_POST) += $(shell if [ -d lib_$(ARCH)/fpu ]; then echo \
+SPLIB-$(CONFIG_SYS_POST_FPU) += $(shell if [ -d lib_$(ARCH)/fpu ]; then echo \
"lib_$(ARCH)/fpu/libpost$(ARCH)fpu.o"; fi)
SPLIB-$(CONFIG_HAS_POST) += $(shell if [ -d cpu/$(CPU) ]; then echo \
"cpu/$(CPU)/libpost$(CPU).o"; fi)
--
1.7.3.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* [U-Boot] [PATCH] post/Makefile: Only build FP post tests if enabled via CONFIG_SYS_POST_FPU 2012-01-12 19:30 [U-Boot] [PATCH] post/Makefile: Only build FP post tests if enabled via CONFIG_SYS_POST_FPU Kumar Gala @ 2012-01-13 19:42 ` Wolfgang Denk 2012-01-13 23:13 ` Wolfgang Denk 2012-03-12 14:04 ` Wolfgang Denk 2 siblings, 0 replies; 6+ messages in thread From: Wolfgang Denk @ 2012-01-13 19:42 UTC (permalink / raw) To: u-boot Dear Kumar Gala, In message <1326396641-20928-1-git-send-email-galak@kernel.crashing.org> you wrote: > Signed-off-by: Kumar Gala <galak@kernel.crashing.org> > --- > post/Makefile | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Insults are effective only where emotion is present. -- Spock, "Who Mourns for Adonais?" stardate 3468.1 ^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] post/Makefile: Only build FP post tests if enabled via CONFIG_SYS_POST_FPU 2012-01-12 19:30 [U-Boot] [PATCH] post/Makefile: Only build FP post tests if enabled via CONFIG_SYS_POST_FPU Kumar Gala 2012-01-13 19:42 ` Wolfgang Denk @ 2012-01-13 23:13 ` Wolfgang Denk 2012-03-04 0:04 ` Wolfgang Denk 2012-03-12 14:04 ` Wolfgang Denk 2 siblings, 1 reply; 6+ messages in thread From: Wolfgang Denk @ 2012-01-13 23:13 UTC (permalink / raw) To: u-boot Dear Kumar Gala, In message <1326396641-20928-1-git-send-email-galak@kernel.crashing.org> you wrote: > Signed-off-by: Kumar Gala <galak@kernel.crashing.org> > --- > post/Makefile | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/post/Makefile b/post/Makefile > index 200e2f1..55b7d21 100644 > --- a/post/Makefile > +++ b/post/Makefile > @@ -32,7 +32,7 @@ COBJS-$(CONFIG_POST_STD_LIST) += tests.o > SPLIB-$(CONFIG_HAS_POST) = drivers/libpostdrivers.o > SPLIB-$(CONFIG_HAS_POST) += $(shell if [ -d lib_$(ARCH) ]; then echo \ > "lib_$(ARCH)/libpost$(ARCH).o"; fi) > -SPLIB-$(CONFIG_HAS_POST) += $(shell if [ -d lib_$(ARCH)/fpu ]; then echo \ > +SPLIB-$(CONFIG_SYS_POST_FPU) += $(shell if [ -d lib_$(ARCH)/fpu ]; then echo \ > "lib_$(ARCH)/fpu/libpost$(ARCH)fpu.o"; fi) > SPLIB-$(CONFIG_HAS_POST) += $(shell if [ -d cpu/$(CPU) ]; then echo \ > "cpu/$(CPU)/libpost$(CPU).o"; fi) Unfortunately I applied this patch without sufficient tesing. It breaks a number of boards: Configuring for korat board... post/libpost.o:(.data.rel.post_list+0xb0): undefined reference to `fpu_post_test' make: *** [/work/wd/tmp-ppc/u-boot] Error 1 powerpc-linux-size: '/work/wd/tmp-ppc/u-boot': No such file Configuring for korat_perm - Board: korat, Options: KORAT_PERMANENT post/libpost.o:(.data.rel.post_list+0xb0): undefined reference to `fpu_post_test' make: *** [/work/wd/tmp-ppc/u-boot] Error 1 powerpc-linux-size: '/work/wd/tmp-ppc/u-boot': No such file Configuring for lwmon5 board... post/libpost.o:(.data.rel.post_list+0xf0): undefined reference to `fpu_post_test' make: *** [/work/wd/tmp-ppc/u-boot] Error 1 powerpc-linux-size: '/work/wd/tmp-ppc/u-boot': No such file Configuring for sequoia - Board: sequoia, Options: SEQUOIA post/libpost.o:(.data.rel.post_list+0x90): undefined reference to `fpu_post_test' make: *** [/work/wd/tmp-ppc/u-boot] Error 1 powerpc-linux-size: '/work/wd/tmp-ppc/u-boot': No such file Configuring for sequoia_nand - Board: sequoia, Options: SEQUOIA,NAND_U_BOOT,SYS_TEXT_BASE=0x01000000 post/libpost.o:(.data.rel.post_list+0x70): undefined reference to `fpu_post_test' make: *** [/work/wd/tmp-ppc/u-boot] Error 1 powerpc-linux-size: '/work/wd/tmp-ppc/u-boot': No such file Configuring for sequoia_ramboot - Board: sequoia, Options: SEQUOIA,SYS_RAMBOOT,SYS_TEXT_BASE=0x01000000,SYS_LDSCRIPT=board/amcc/sequoia/u-boot-ram.lds post/libpost.o:(.data.rel.post_list+0x70): undefined reference to `fpu_post_test' make: *** [/work/wd/tmp-ppc/u-boot] Error 1 powerpc-linux-size: '/work/wd/tmp-ppc/u-boot': No such file Configuring for PMC440 board... post/libpost.o:(.data.rel.post_list+0x90): undefined reference to `fpu_post_test' make: *** [/work/wd/tmp-ppc/u-boot] Error 1 powerpc-linux-size: '/work/wd/tmp-ppc/u-boot': No such file Please provide a fix. Alternatively I can revert that patch. Thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Life. Don't talk to me about life. - Marvin the Paranoid Android ^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] post/Makefile: Only build FP post tests if enabled via CONFIG_SYS_POST_FPU 2012-01-13 23:13 ` Wolfgang Denk @ 2012-03-04 0:04 ` Wolfgang Denk 2012-03-05 5:56 ` Marek Vasut 0 siblings, 1 reply; 6+ messages in thread From: Wolfgang Denk @ 2012-03-04 0:04 UTC (permalink / raw) To: u-boot Dear Andy, In message <20120113231310.8EADD11CDEDB@gemini.denx.de> I wrote: > Dear Kumar Gala, > > In message <1326396641-20928-1-git-send-email-galak@kernel.crashing.org> you wrote: > > Signed-off-by: Kumar Gala <galak@kernel.crashing.org> > > --- > > post/Makefile | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/post/Makefile b/post/Makefile > > index 200e2f1..55b7d21 100644 > > --- a/post/Makefile > > +++ b/post/Makefile > > @@ -32,7 +32,7 @@ COBJS-$(CONFIG_POST_STD_LIST) += tests.o > > SPLIB-$(CONFIG_HAS_POST) = drivers/libpostdrivers.o > > SPLIB-$(CONFIG_HAS_POST) += $(shell if [ -d lib_$(ARCH) ]; then echo \ > > "lib_$(ARCH)/libpost$(ARCH).o"; fi) > > -SPLIB-$(CONFIG_HAS_POST) += $(shell if [ -d lib_$(ARCH)/fpu ]; then echo \ > > +SPLIB-$(CONFIG_SYS_POST_FPU) += $(shell if [ -d lib_$(ARCH)/fpu ]; then echo \ > > "lib_$(ARCH)/fpu/libpost$(ARCH)fpu.o"; fi) > > SPLIB-$(CONFIG_HAS_POST) += $(shell if [ -d cpu/$(CPU) ]; then echo \ > > "cpu/$(CPU)/libpost$(CPU).o"; fi) > > Unfortunately I applied this patch without sufficient tesing. It > breaks a number of boards: > > Configuring for korat board... > post/libpost.o:(.data.rel.post_list+0xb0): undefined reference to `fpu_post_test' > make: *** [/work/wd/tmp-ppc/u-boot] Error 1 > powerpc-linux-size: '/work/wd/tmp-ppc/u-boot': No such file > Configuring for korat_perm - Board: korat, Options: KORAT_PERMANENT > post/libpost.o:(.data.rel.post_list+0xb0): undefined reference to `fpu_post_test' > make: *** [/work/wd/tmp-ppc/u-boot] Error 1 > powerpc-linux-size: '/work/wd/tmp-ppc/u-boot': No such file > Configuring for lwmon5 board... > post/libpost.o:(.data.rel.post_list+0xf0): undefined reference to `fpu_post_test' > make: *** [/work/wd/tmp-ppc/u-boot] Error 1 > powerpc-linux-size: '/work/wd/tmp-ppc/u-boot': No such file > Configuring for sequoia - Board: sequoia, Options: SEQUOIA > post/libpost.o:(.data.rel.post_list+0x90): undefined reference to `fpu_post_test' > make: *** [/work/wd/tmp-ppc/u-boot] Error 1 > powerpc-linux-size: '/work/wd/tmp-ppc/u-boot': No such file > Configuring for sequoia_nand - Board: sequoia, Options: SEQUOIA,NAND_U_BOOT,SYS_TEXT_BASE=0x01000000 > post/libpost.o:(.data.rel.post_list+0x70): undefined reference to `fpu_post_test' > make: *** [/work/wd/tmp-ppc/u-boot] Error 1 > powerpc-linux-size: '/work/wd/tmp-ppc/u-boot': No such file > Configuring for sequoia_ramboot - Board: sequoia, Options: SEQUOIA,SYS_RAMBOOT,SYS_TEXT_BASE=0x01000000,SYS_LDSCRIPT=board/amcc/sequoia/u-boot-ram.lds > post/libpost.o:(.data.rel.post_list+0x70): undefined reference to `fpu_post_test' > make: *** [/work/wd/tmp-ppc/u-boot] Error 1 > powerpc-linux-size: '/work/wd/tmp-ppc/u-boot': No such file > Configuring for PMC440 board... > post/libpost.o:(.data.rel.post_list+0x90): undefined reference to `fpu_post_test' > make: *** [/work/wd/tmp-ppc/u-boot] Error 1 > powerpc-linux-size: '/work/wd/tmp-ppc/u-boot': No such file > > > Please provide a fix. Alternatively I can revert that patch. Kumar never replied, and nobody else picked this up either. Do you feel you "inherit" such stuff from Kumar? Or should I just revert the commit? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Without freedom of choice there is no creativity. -- Kirk, "The return of the Archons", stardate 3157.4 ^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] post/Makefile: Only build FP post tests if enabled via CONFIG_SYS_POST_FPU 2012-03-04 0:04 ` Wolfgang Denk @ 2012-03-05 5:56 ` Marek Vasut 0 siblings, 0 replies; 6+ messages in thread From: Marek Vasut @ 2012-03-05 5:56 UTC (permalink / raw) To: u-boot Dear Wolfgang Denk, > Dear Andy, > > In message <20120113231310.8EADD11CDEDB@gemini.denx.de> I wrote: > > Dear Kumar Gala, > > > > In message <1326396641-20928-1-git-send-email-galak@kernel.crashing.org> you wrote: > > > Signed-off-by: Kumar Gala <galak@kernel.crashing.org> > > > --- > > > > > > post/Makefile | 2 +- > > > 1 files changed, 1 insertions(+), 1 deletions(-) [...] > > Please provide a fix. Alternatively I can revert that patch. > > Kumar never replied, and nobody else picked this up either. Do you > feel you "inherit" such stuff from Kumar? > > Or should I just revert the commit? > > Best regards, > > Wolfgang Denk please revert until fixed, it causes bleeps on the jenk-radar. Best regards, Marek Vasut ^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] post/Makefile: Only build FP post tests if enabled via CONFIG_SYS_POST_FPU 2012-01-12 19:30 [U-Boot] [PATCH] post/Makefile: Only build FP post tests if enabled via CONFIG_SYS_POST_FPU Kumar Gala 2012-01-13 19:42 ` Wolfgang Denk 2012-01-13 23:13 ` Wolfgang Denk @ 2012-03-12 14:04 ` Wolfgang Denk 2 siblings, 0 replies; 6+ messages in thread From: Wolfgang Denk @ 2012-03-12 14:04 UTC (permalink / raw) To: u-boot Dear Kumar & Andy, In message <1326396641-20928-1-git-send-email-galak@kernel.crashing.org> you wrote: > Signed-off-by: Kumar Gala <galak@kernel.crashing.org> > --- > post/Makefile | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) As this patch breaks a number of boards and I get neithe ra fix nor even a reply, I hereby revert it. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de As of 1992, they're called European Economic Community fries. ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-03-12 14:04 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2012-01-12 19:30 [U-Boot] [PATCH] post/Makefile: Only build FP post tests if enabled via CONFIG_SYS_POST_FPU Kumar Gala 2012-01-13 19:42 ` Wolfgang Denk 2012-01-13 23:13 ` Wolfgang Denk 2012-03-04 0:04 ` Wolfgang Denk 2012-03-05 5:56 ` Marek Vasut 2012-03-12 14:04 ` Wolfgang Denk
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox