From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] MAKEALL: Add -m/-M option to determine maintainers
Date: Mon, 5 Mar 2012 18:08:07 -0500 [thread overview]
Message-ID: <201203051808.11351.vapier@gentoo.org> (raw)
In-Reply-To: <1330981868-29895-1-git-send-email-marex@denx.de>
On Monday 05 March 2012 16:11:08 Marek Vasut wrote:
> +get_target_location() {
> + target=$1
> +
> + BOARD_NAME=""
> + CONFIG_NAME=""
> + board=""
> + vendor=""
please use "local" when declaring variables that are function local
> + line=`egrep -i "^[[:space:]]*${target}[[:space:]]" boards.cfg`
obviously i prefer $(...) rather than `...`
> + if [ -z "${line}" ] ; then echo "" ; return ; fi
please unroll
> + [ "${BOARD_NAME}" ] || BOARD_NAME="${1%_config}"
: ${BOARD_NAME:=${1%_config}}
> + [ $# -gt 6 ] && [ "$7" != "-" ] && {
please use:
if ... ; then
> + if ! grep -i ${name} MAINTAINERS >/dev/null 2>&1 ; then
use -qs and then you can drop the redirects
> + return ;
drop the semi-colon
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120305/31a62205/attachment.pgp>
next prev parent reply other threads:[~2012-03-05 23:08 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-05 17:33 [U-Boot] [PATCH] MAKEALL: Add -m option to determine maintainers Marek Vasut
2012-03-05 19:15 ` Wolfgang Denk
2012-03-05 20:14 ` Marek Vasut
2012-03-05 20:27 ` Wolfgang Denk
2012-03-05 20:37 ` Marek Vasut
2012-03-05 20:35 ` [U-Boot] [PATCH V2] MAKEALL: Add -m/-M " Marek Vasut
2012-03-05 20:38 ` Marek Vasut
2012-03-05 21:11 ` [U-Boot] [PATCH] " Marek Vasut
2012-03-05 21:30 ` Wolfgang Denk
2012-03-05 23:08 ` Mike Frysinger [this message]
2012-03-06 1:10 ` [U-Boot] [PATCH V4] " Marek Vasut
2012-03-20 20:54 ` Marek Vasut
2012-03-30 20:35 ` Wolfgang Denk
2012-03-30 20:46 ` Marek Vasut
2012-04-08 8:45 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201203051808.11351.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox