From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/4] net: fec_mxc: allow use with cache enabled
Date: Mon, 5 Mar 2012 18:59:21 +0100 [thread overview]
Message-ID: <201203051859.21952.marex@denx.de> (raw)
In-Reply-To: <4F54E1FB.4090000@boundarydevices.com>
Dear Eric Nelson,
> On 03/05/2012 08:39 AM, Marek Vasut wrote:
> > Dear Eric Nelson,
> >
> >> On 03/04/2012 06:49 PM, Marek Vasut wrote:
> >>>> On 03/02/2012 04:39 PM, Marek Vasut wrote:
> >>>>>> + * Invalidate data cache over the buffer
> >>>>>> + */
> >>>>>> + addr = (uint32_t)frame;
> >>>>>> + size = roundup(frame_length,
> >
> > CONFIG_FEC_DATA_ALIGNMENT);
> >
> >>>>>> + invalidate_dcache_range(addr, addr + size);
> >>>>>
> >>>>> DTTO here, frame length might not be aligned properly, or will it be?
> >>>>> Network stack must be properly analyzed here.
> >>>>
> >>>> The hardware won't return an unaligned value here, so this should be
> >>>> good.
> >>>
> >>> Are you sure? You can't receive frame aligned to 8 bytes boundary?
> >>
> >> Unless I'm missing something, received packet start addresses are
> >> defined by the driver in fec_rbd_init(), the code just modified to use
> >> memalign, so we're good here.
> >
> > Ok, that's good then. I'll skim through this driver one more time tonight
> > and see what comes out from it.
>
> Thanks.
>
> I just sent V2.
I can't seem to find it, did you really send it?
Best regards,
Marek Vasut
next prev parent reply other threads:[~2012-03-05 17:59 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-02 23:06 [U-Boot] [PATCH 0/4] Add preliminary cache support to i.MX6 Eric Nelson
2012-03-02 23:06 ` [U-Boot] [PATCH 1/4] i.MX6: define CACHELINE_SIZE Eric Nelson
2012-03-02 23:25 ` Marek Vasut
2012-03-02 23:06 ` [U-Boot] [PATCH 2/4] net: fec_mxc: allow use with cache enabled Eric Nelson
2012-03-02 23:15 ` Eric Nelson
2012-03-02 23:40 ` Marek Vasut
2012-03-02 23:50 ` Eric Nelson
2012-03-02 23:39 ` Marek Vasut
2012-03-04 23:13 ` Eric Nelson
2012-03-05 1:49 ` Marek Vasut
2012-03-05 13:43 ` Eric Nelson
2012-03-05 15:39 ` Marek Vasut
2012-03-05 15:55 ` Eric Nelson
2012-03-05 17:59 ` Marek Vasut [this message]
2012-03-05 18:37 ` Eric Nelson
2012-03-02 23:41 ` Eric Nelson
2012-03-02 23:06 ` [U-Boot] [PATCH 3/4] i.MX6: implement enable_caches() Eric Nelson
2012-03-02 23:26 ` Marek Vasut
2012-03-02 23:06 ` [U-Boot] [PATCH 4/4] i.MX6: mx6qsabrelite: add cache commands if cache is enabled Eric Nelson
2012-03-02 23:26 ` Marek Vasut
2012-03-02 23:21 ` [U-Boot] [PATCH 0/4] Add preliminary cache support to i.MX6 Eric Nelson
2012-03-02 23:25 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201203051859.21952.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox