From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] MAKEALL: Add -m option to determine maintainers
Date: Mon, 5 Mar 2012 21:14:09 +0100 [thread overview]
Message-ID: <201203052114.10141.marex@denx.de> (raw)
In-Reply-To: <20120305191501.0C4BB202D68@gemini.denx.de>
Dear Wolfgang Denk,
> Dear Marek Vasut,
>
> In message <1330968789-17997-1-git-send-email-marex@denx.de> you wrote:
> > The -m option lists boards including their maintainers emails. There are
> > multiple strategies used to retrieve these emails:
> >
> > 1) Check board/<boardname> with git log and use three most recent emails
> > 2) Check board/<boardname> with git log and use three most used emails
> > 3) Try finding board in MAINTAINERS file and retrieve all emails from
> > there
>
> I think if the board can be found in MAINTAINERS, this should have
> preference, i. e. always printed first. Normaly, it should be the
> only address printed.
Ok, not a bad idea indeed.
>
> We might also want to double-check git log based resutls against
> include/configs/<name>.h - this file is way more often edited by the
> maintainers.
Ok.
>
> Eventually "-m" should just print one address; we could add "-M" for all
> found addresses.
Ack.
>
> > The result is then sorted and unique results are retrieved and reported.
> >
> > Signed-off-by: Marek Vasut <marex@denx.de>
> > Cc: Wolfgang Denk <wd@denx.de>
> > ---
> >
> > MAKEALL | 91
> > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-- 1 files
> > changed, 88 insertions(+), 3 deletions(-)
>
> Hm... there are also problems with the code:
>
> -> ./MAKEALL -m TQM860L
> tail: cannot open `1090' for reading: No such file or directory
> TQM860L: Joakim.Tjernlund at transmode.se plagnioj at jcrosoft.com
> ptyser at xes-inc.com wd at denx.de
>
> What's this "tail" error?
Yes, thanks for finding this. We have multiple TQM860L in MAINTAINERS.
>
> -> ./MAKEALL -m mpc8xx
> fatal: ambiguous argument 'board/extquote': unknown revision or path not
> in the working tree. Use '--' to separate paths from revisions
> mpc8xx:
>
> Doesn't work at all.
>
What's this supposed to do? You mean ./MAKEALL -m -c mpc8xx (missing -c) ?
>
>
> Best regards,
>
> Wolfgang Denk
Best regards,
Marek Vasut
next prev parent reply other threads:[~2012-03-05 20:14 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-05 17:33 [U-Boot] [PATCH] MAKEALL: Add -m option to determine maintainers Marek Vasut
2012-03-05 19:15 ` Wolfgang Denk
2012-03-05 20:14 ` Marek Vasut [this message]
2012-03-05 20:27 ` Wolfgang Denk
2012-03-05 20:37 ` Marek Vasut
2012-03-05 20:35 ` [U-Boot] [PATCH V2] MAKEALL: Add -m/-M " Marek Vasut
2012-03-05 20:38 ` Marek Vasut
2012-03-05 21:11 ` [U-Boot] [PATCH] " Marek Vasut
2012-03-05 21:30 ` Wolfgang Denk
2012-03-05 23:08 ` Mike Frysinger
2012-03-06 1:10 ` [U-Boot] [PATCH V4] " Marek Vasut
2012-03-20 20:54 ` Marek Vasut
2012-03-30 20:35 ` Wolfgang Denk
2012-03-30 20:46 ` Marek Vasut
2012-04-08 8:45 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201203052114.10141.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox