From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marex@denx.de>
Date: Mon, 5 Mar 2012 21:14:09 +0100
Subject: [U-Boot] [PATCH] MAKEALL: Add -m option to determine maintainers
In-Reply-To: <20120305191501.0C4BB202D68@gemini.denx.de>
References: <1330968789-17997-1-git-send-email-marex@denx.de>
	<20120305191501.0C4BB202D68@gemini.denx.de>
Message-ID: <201203052114.10141.marex@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Wolfgang Denk,

> Dear Marek Vasut,
> 
> In message <1330968789-17997-1-git-send-email-marex@denx.de> you wrote:
> > The -m option lists boards including their maintainers emails. There are
> > multiple strategies used to retrieve these emails:
> > 
> > 1) Check board/<boardname> with git log and use three most recent emails
> > 2) Check board/<boardname> with git log and use three most used emails
> > 3) Try finding board in MAINTAINERS file and retrieve all emails from
> > there
> 
> I think if the board can be found in MAINTAINERS, this should have
> preference, i. e. always printed first.  Normaly, it should be the
> only address printed.

Ok, not a bad idea indeed.

> 
> We might also want to double-check git log based resutls against
> include/configs/<name>.h - this file is way more often edited by the
> maintainers.

Ok.

> 
> Eventually "-m" should just print one address; we could add "-M" for all
> found addresses.

Ack.

> 
> > The result is then sorted and unique results are retrieved and reported.
> > 
> > Signed-off-by: Marek Vasut <marex@denx.de>
> > Cc: Wolfgang Denk <wd@denx.de>
> > ---
> > 
> >  MAKEALL |   91
> >  ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-- 1 files
> >  changed, 88 insertions(+), 3 deletions(-)
> 
> Hm... there are also problems with the code:
> 
> 	-> ./MAKEALL -m TQM860L
> 	tail: cannot open `1090' for reading: No such file or directory
> 	TQM860L: Joakim.Tjernlund at transmode.se plagnioj at jcrosoft.com
> ptyser at xes-inc.com wd at denx.de
> 
> What's this "tail" error?

Yes, thanks for finding this. We have multiple TQM860L in MAINTAINERS.

> 
> 	-> ./MAKEALL -m mpc8xx
> 	fatal: ambiguous argument 'board/extquote': unknown revision or path not
> in the working tree. Use '--' to separate paths from revisions
> 	mpc8xx:
> 
> Doesn't work at all.
> 

What's this supposed to do? You mean ./MAKEALL -m -c mpc8xx (missing -c) ?

> 
> 
> Best regards,
> 
> Wolfgang Denk

Best regards,
Marek Vasut