From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marex@denx.de>
Date: Tue, 6 Mar 2012 01:37:44 +0100
Subject: [U-Boot] [PATCH 6/6] IXP: Fix NAND build warning on PDNB3 and
	SCPU
In-Reply-To: <4F555BE7.2020909@freescale.com>
References: <1330992781-1394-1-git-send-email-marex@denx.de>
	<1330992781-1394-7-git-send-email-marex@denx.de>
	<4F555BE7.2020909@freescale.com>
Message-ID: <201203060137.44399.marex@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Scott Wood,

> On 03/05/2012 06:13 PM, Marek Vasut wrote:
> > nand.c: In function ?pdnb3_nand_read_buf?:
> > nand.c:107:4: warning: dereferencing type-punned pointer will break
> > strict-aliasing rules [-Wstrict-aliasing] nand.c: In function
> > ?pdnb3_nand_dev_ready?:
> > nand.c:124:18: warning: variable ?val? set but not used
> > [-Wunused-but-set-variable]
> > 
> > Signed-off-by: Marek Vasut <marex@denx.de>
> > Cc: Bryan Hundven <bryanhundven@gmail.com>
> > Cc: Michael Schwingen <rincewind@discworld.dascon.de>
> > ---
> > 
> >  board/prodrive/pdnb3/nand.c |    9 ++++++---
> >  1 files changed, 6 insertions(+), 3 deletions(-)
> > 
> > diff --git a/board/prodrive/pdnb3/nand.c b/board/prodrive/pdnb3/nand.c
> > index 2efe027..656fafe 100644
> > --- a/board/prodrive/pdnb3/nand.c
> > +++ b/board/prodrive/pdnb3/nand.c
> > @@ -100,11 +100,14 @@ static void pdnb3_nand_read_buf(struct mtd_info
> > *mtd, u_char *buf, int len)
> > 
> >  		for (i = 0; i < len; i++)
> >  		
> >  			buf[i] = readb(&(pdnb3_ndfc->data));
> >  	
> >  	} else {
> > 
> > -		ulong *ptr = (ulong *)buf;
> > +		uint32_t data;
> > 
> >  		int count = len >> 2;
> > 
> > -		for (i = 0; i < count; i++)
> > -			*ptr++ = readl(&(pdnb3_ndfc->data));
> > +		for (i = 0; i < count; i++) {
> > +			data = readl(&pdnb3_ndfc->data);
> > +			memcpy(buf, &data, 4);
> > +			buf += 4;
> > +		}
> > 
> >  	}
> >  
> >  }
> 
> Any reason this isn't in drivers/mtd/nand?
> 
> -Scott

Don't ask me ... and it's similar with IXP NPE ethernet :-(

Best regards,
Marek Vasut