From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Roese Date: Wed, 7 Mar 2012 14:21:08 +0100 Subject: [U-Boot] [PATCH 03/25] SPEAr: Place ethaddr write and read within CONFIG_CMD_NET In-Reply-To: <1331121854-20494-4-git-send-email-amit.virdi@st.com> References: <1331121854-20494-1-git-send-email-amit.virdi@st.com> <1331121854-20494-4-git-send-email-amit.virdi@st.com> Message-ID: <201203071421.08705.sr@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wednesday 07 March 2012 13:03:52 Amit Virdi wrote: > From: Vipin KUMAR > > ethaddr can be optionally read from i2c memory. So, chip_config command > supports reading/writing hw mac id into i2c memory. Placing this code > within CONFIG_CMD_NET as this would only be needed when network interface > is configured > > Signed-off-by: Vipin Kumar > Signed-off-by: Amit Virdi I'm not really sure, why you have this special ethaddr handling in I2C prom here at all. Isn't it enough to have the MAC address (ethaddr) stored in the U-Boot environment (NOR, NAND, etc)? Why do you need this additional I2C stuff? Could you please explain this? Thanks, Stefan -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de