public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 15/25] SPEAr: Enable autoneg for ethernet
Date: Wed, 7 Mar 2012 15:18:53 +0100	[thread overview]
Message-ID: <201203071518.53629.sr@denx.de> (raw)
In-Reply-To: <1331121854-20494-16-git-send-email-amit.virdi@st.com>

On Wednesday 07 March 2012 13:04:04 Amit Virdi wrote:
> From: Shiraz Hashim <shiraz.hashim@st.com>
> 
> The linux-2.6.37 base port has few problems with nfs boot. The boot
> fails while getting timeout on attempting to mount root file system.
> This helps the ethernet to bring up faster in linux boot thus avoiding
> the time out.
> Besides, it was reported that few phys on SPEAr board are failing in
> certain network conditions which is avoided by enabling autonegotiation.
> See issue #115943 in global bug tracker.

Hmmm. This sounds like a problem in the Linux network/PHY code then. Which 
needs to get fixed there instead of changing something here in U-Boot. Please 
think about situations where the ethernet driver is not called at all in U-
Boot (booting from NOR/NAND). With my changes to defer the ethernet probing to 
the first usage.

One more comment below.

> Reported-by: Deepak Sikri <deepak.sikri@st.com>
> Reported-by: Armando Visconti <armando.visconti@st.com>
> Signed-off-by: Shiraz Hashim <shiraz.hashim@st.com>
> Signed-off-by: Amit Virdi <amit.virdi@st.com>
> ---
>  include/configs/spear-common.h |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/include/configs/spear-common.h
> b/include/configs/spear-common.h index 5b6ef72..26642f1 100644
> --- a/include/configs/spear-common.h
> +++ b/include/configs/spear-common.h
> @@ -35,6 +35,7 @@
>  #define CONFIG_DW0_PHY				1
>  #define CONFIG_NET_MULTI
>  #define CONFIG_PHY_RESET_DELAY			(10000)		/* 
in usec */
> +#define CONFIG_DW_AUTONEG			1

Please don't add the "1" here.

>  #endif
> 
>  /* USBD driver configuration */

-- 
Viele Gr??e,
Stefan

--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de

  reply	other threads:[~2012-03-07 14:18 UTC|newest]

Thread overview: 79+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-07 12:03 [U-Boot] [PATCH 00/25] SPEAr: Update platform support for SPEAr3xx/6xx Amit Virdi
2012-03-07 12:03 ` [U-Boot] [PATCH 01/25] SPEAr: Fix ARM relocation support Amit Virdi
2012-03-07 13:11   ` Stefan Roese
2012-03-07 12:03 ` [U-Boot] [PATCH 02/25] SPEAr: Eliminate dependency on Xloader table Amit Virdi
2012-03-07 13:16   ` Stefan Roese
2012-03-07 12:03 ` [U-Boot] [PATCH 03/25] SPEAr: Place ethaddr write and read within CONFIG_CMD_NET Amit Virdi
2012-03-07 13:21   ` Stefan Roese
2012-03-07 13:29     ` Mike Frysinger
2012-03-26 11:23     ` Amit Virdi
2012-03-26 13:15       ` Wolfgang Denk
2012-03-07 12:03 ` [U-Boot] [PATCH 04/25] SPEAr: Configure network support for spear SoCs Amit Virdi
2012-03-07 13:29   ` Stefan Roese
2012-03-26 11:41     ` Amit Virdi
2012-03-26 11:51       ` Stefan Roese
2012-03-07 12:03 ` [U-Boot] [PATCH 05/25] SPEAr: Add macb driver support for spear310 and spear320 Amit Virdi
2012-03-07 12:03 ` [U-Boot] [PATCH 06/25] SPEAr: Add interface information in initialization Amit Virdi
2012-03-07 12:03 ` [U-Boot] [PATCH 07/25] SPEAr: Add basic arch related support for SPEAr SoCs Amit Virdi
2012-03-07 13:49   ` Stefan Roese
2012-03-12 12:30     ` Amit Virdi
2012-03-07 12:03 ` [U-Boot] [PATCH 08/25] SPEAr: Add configuration options for spear3xx and spear6xx boards Amit Virdi
2012-03-07 13:54   ` Stefan Roese
2012-03-26 12:10     ` Amit Virdi
2012-03-26 12:30       ` Stefan Roese
2012-03-27  5:59         ` Amit Virdi
2012-03-07 12:03 ` [U-Boot] [PATCH 09/25] SPEAr: Remove unused flag (CONFIG_SYS_HZ_CLOCK) Amit Virdi
2012-03-07 13:56   ` Stefan Roese
2012-03-07 12:03 ` [U-Boot] [PATCH 10/25] SPEAr: Change the default environment variables Amit Virdi
2012-03-07 14:03   ` Stefan Roese
2012-03-12 12:38     ` Amit Virdi
2012-03-07 12:04 ` [U-Boot] [PATCH 11/25] SPEAr: Initialize SNOR in early_board_init_f Amit Virdi
2012-03-07 14:06   ` Stefan Roese
2012-03-07 12:04 ` [U-Boot] [PATCH 12/25] SPEAr: Enable usb device high speed support Amit Virdi
2012-03-07 14:07   ` Stefan Roese
2012-03-12 12:39     ` Amit Virdi
2012-03-26 12:15       ` Amit Virdi
2012-03-07 12:04 ` [U-Boot] [PATCH 13/25] SPEAr: spear usbtty configuration does not use ethernet device Amit Virdi
2012-03-07 14:14   ` Stefan Roese
2012-03-12 13:12     ` Amit Virdi
2012-03-07 12:04 ` [U-Boot] [PATCH 14/25] SPEAr: Enable udc and usb-console support only for usbtty configuration Amit Virdi
2012-03-07 14:15   ` Stefan Roese
2012-03-07 12:04 ` [U-Boot] [PATCH 15/25] SPEAr: Enable autoneg for ethernet Amit Virdi
2012-03-07 14:18   ` Stefan Roese [this message]
2012-03-27  9:02     ` Amit Virdi
2012-03-27  9:20       ` Stefan Roese
2012-03-27  9:24         ` Amit Virdi
2012-03-07 12:04 ` [U-Boot] [PATCH 16/25] SPEAr: Enable dcache for fast file transfer Amit Virdi
2012-03-07 12:04 ` [U-Boot] [PATCH 17/25] SPEAr: Enable CONFIG_SYS_FLASH_PROTECTION Amit Virdi
2012-03-07 14:25   ` Stefan Roese
2012-03-27  6:39     ` Amit Virdi
2012-03-07 12:04 ` [U-Boot] [PATCH 18/25] SPEAr: Correct the definition of CONFIG_SYS_MONITOR_BASE Amit Virdi
2012-03-07 14:31   ` Stefan Roese
2012-03-27  6:38     ` Amit Virdi
2012-03-27  7:05       ` Stefan Roese
2012-03-27  7:42         ` Amit Virdi
2012-03-07 12:04 ` [U-Boot] [PATCH 19/25] SPEAr: Enable CONFIG_SYS_FLASH_EMPTY_INFO macro Amit Virdi
2012-03-07 14:32   ` Stefan Roese
2012-03-27  6:11     ` Amit Virdi
2012-03-07 12:04 ` [U-Boot] [PATCH 20/25] SPEAr: Enable ONFI nand flash detection for spear3xx and 6xx and evb Amit Virdi
2012-03-07 14:34   ` Stefan Roese
2012-03-27  6:09     ` Amit Virdi
2012-03-07 12:04 ` [U-Boot] [PATCH 21/25] SPEAr: explicitly select clk src for UART Amit Virdi
2012-03-07 14:36   ` Stefan Roese
2012-03-07 12:04 ` [U-Boot] [PATCH 22/25] SPEAr: Correct SoC ID offset in misc configuration space Amit Virdi
2012-03-07 14:36   ` Stefan Roese
2012-03-07 12:04 ` [U-Boot] [PATCH 23/25] SPEAr: Use separate config flags for 3xx and 6xx board files Amit Virdi
2012-03-07 14:38   ` Stefan Roese
2012-03-12 13:57     ` Amit Virdi
2012-03-12 14:17       ` Stefan Roese
2012-03-07 12:04 ` [U-Boot] [PATCH 24/25] cleanup/SPEAr: Remove unnecessary parenthesis Amit Virdi
2012-03-07 14:41   ` Stefan Roese
2012-03-07 14:46     ` Stefan Roese
2012-03-12 13:52       ` Amit Virdi
2012-03-07 12:04 ` [U-Boot] [PATCH 25/25] cleanup/SPEAr: Define configuration flags more elegantly Amit Virdi
2012-03-07 14:42   ` Stefan Roese
2012-03-07 13:15 ` [U-Boot] [PATCH 00/25] SPEAr: Update platform support for SPEAr3xx/6xx Stefan Roese
2012-03-07 13:56   ` Amit Virdi
2012-03-09  7:29   ` Vipin Kumar
2012-03-09  7:47     ` Stefan Roese
2012-03-09  8:47       ` Vipin Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201203071518.53629.sr@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox