From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefan Roese <sr@denx.de>
Date: Wed, 7 Mar 2012 15:38:59 +0100
Subject: [U-Boot] [PATCH 23/25] SPEAr: Use separate config flags for 3xx
	and 6xx board files
In-Reply-To: <1331121854-20494-24-git-send-email-amit.virdi@st.com>
References: <1331121854-20494-1-git-send-email-amit.virdi@st.com>
	<1331121854-20494-24-git-send-email-amit.virdi@st.com>
Message-ID: <201203071538.59432.sr@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Wednesday 07 March 2012 13:04:12 Amit Virdi wrote:
> Signed-off-by: Amit Virdi <amit.virdi@st.com>
> ---
>  board/spear/common/Makefile |    9 +++++++--
>  1 files changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/board/spear/common/Makefile b/board/spear/common/Makefile
> index 11f81e4..48dcfd3 100644
> --- a/board/spear/common/Makefile
> +++ b/board/spear/common/Makefile
> @@ -29,9 +29,14 @@ endif
> 
>  LIB	= $(obj)lib$(VENDOR).o
> 
> -COBJS	:= spr_misc.o
> -SOBJS	:= spr_lowlevel_init.o
> +COBJS-$(CONFIG_SPEAR3XX) += spr_misc.o
> +COBJS-$(CONFIG_SPEAR600) += spr_misc.o
> 
> +SOBJS-$(CONFIG_SPEAR3XX) += spr_lowlevel_init.o
> +SOBJS-$(CONFIG_SPEAR600) += spr_lowlevel_init.o
> +
> +COBJS	:= $(sort $(COBJS-y))
> +SOBJS	:= $(sort $(SOBJS-y))
>  SRCS	:= $(SOBJS:.o=.S) $(COBJS:.o=.c)
>  OBJS	:= $(addprefix $(obj),$(COBJS))
>  SOBJS	:= $(addprefix $(obj),$(SOBJS))

I don't really see the benefit of this patch. Could you please explain a bit 
more why this is needed/better?

Thanks,
Stefan

--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de