From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 3/4] tegra: Implement pre-console putc() for fdt warning
Date: Sat, 10 Mar 2012 09:16:20 +0100 [thread overview]
Message-ID: <20120310081620.CB434202C07@gemini.denx.de> (raw)
In-Reply-To: <1331325178-14634-3-git-send-email-sjg@chromium.org>
Dear Simon Glass,
In message <1331325178-14634-3-git-send-email-sjg@chromium.org> you wrote:
> When there is not device tree file available to U-Boot, we panic.
> Implement board_pre_console_putc() so that this panic will be displayed
> on the serial console.
...
> +void board_pre_console_putc(int ch)
> +{
...
> + for (uart_addr = uart_reg_addr; *uart_addr; uart_addr++) {
> + NS16550_t regs = (NS16550_t)*uart_addr;
> +
> + NS16550_init(regs, divisor);
> + NS16550_putc(regs, ch);
> + if (ch == '\n')
> + NS16550_putc(regs, '\r');
> + NS16550_drain(regs);
Why is this needed for every output character?
Actually, why is it needed at all?
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
All a hacker needs is a tight PUSHJ, a loose pair of UUOs, and a warm
place to shift.
next prev parent reply other threads:[~2012-03-10 8:16 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-09 20:32 [U-Boot] [PATCH v2 1/4] ns16550: Add function to drain serial output Simon Glass
2012-03-09 20:32 ` [U-Boot] [PATCH v2 2/4] Enable printf() console if pre-console putc() is available Simon Glass
2012-03-09 20:32 ` [U-Boot] [PATCH v2 3/4] tegra: Implement pre-console putc() for fdt warning Simon Glass
2012-03-10 8:16 ` Wolfgang Denk [this message]
2012-03-10 19:22 ` Simon Glass
2012-03-10 20:08 ` Wolfgang Denk
2012-03-10 21:25 ` Simon Glass
2012-03-10 22:49 ` Wolfgang Denk
2012-03-11 0:48 ` Simon Glass
2012-03-09 20:32 ` [U-Boot] [PATCH v2 4/4] tegra: Enable pre-console putc() for Tegra boards Simon Glass
2012-03-09 20:59 ` [U-Boot] [PATCH v2 1/4] ns16550: Add function to drain serial output Tom Warren
2012-03-10 8:20 ` Wolfgang Denk
2012-03-09 21:00 ` Stephen Warren
2012-03-09 21:08 ` Simon Glass
2012-03-09 21:23 ` Tom Warren
2012-03-09 21:29 ` Simon Glass
2012-03-09 21:40 ` Stephen Warren
2012-03-10 8:19 ` Wolfgang Denk
2012-03-10 19:27 ` Simon Glass
2012-03-10 20:24 ` Wolfgang Denk
2012-03-11 0:52 ` Simon Glass
2012-03-11 2:06 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120310081620.CB434202C07@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox