public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Sughosh Ganu <urwithsughosh@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] arm: Don't use printf() in SPL builds
Date: Sat, 10 Mar 2012 14:03:45 +0530	[thread overview]
Message-ID: <20120310083345.GA6861@Hardy> (raw)
In-Reply-To: <1330806795-20763-1-git-send-email-sjg@chromium.org>

hi Simon,

On Sat Mar 03, 2012 at 12:33:15PM -0800, Simon Glass wrote:
> raise() likes to call printf() if it is available, but in SPL builds it
> either is not available, or adds a large chunk to the resulting image
> size.
> 
> So don't call it even if it is available.
> 
> This change reduces SPL size from 10KB to 6.3KB on hawkboard, for
> example, using generic relocation.
> 
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
>  arch/arm/lib/eabi_compat.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/arm/lib/eabi_compat.c b/arch/arm/lib/eabi_compat.c
> index 2028dbd..44eebe0 100644
> --- a/arch/arm/lib/eabi_compat.c
> +++ b/arch/arm/lib/eabi_compat.c
> @@ -13,7 +13,8 @@
>  
>  int raise (int signum)
>  {
> -#if !defined(CONFIG_SPL_BUILD) || defined(CONFIG_SPL_LIBCOMMON_SUPPORT)
> +	/* Even if printf() is available, it's large. Punt it for SPL builds */
> +#if !defined(CONFIG_SPL_BUILD)
>  	printf("raise: Signal # %d caught\n", signum);
>  #endif

   I tested with this change on hawkboard, and after applying this
   change, the spl size increase is 412 bytes against the 4k increase
   that we get with libcommon changes introduced. So this patch works
   fine.

   Can you please check if libcommon support is needed for the
   cam_enc_4xx board -- your relocation patch series did not add
   CONFIG_SPL_LIBCOMMON_SUPPORT to this board. This will affect my
   patch to initialise gd and bd objects for hawkboard. Please let me
   know, and i will spin a patch accordingly.

-sughosh

  parent reply	other threads:[~2012-03-10  8:33 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-03 20:33 [U-Boot] [PATCH] arm: Don't use printf() in SPL builds Simon Glass
2012-03-05  8:21 ` Stefan Roese
2012-03-10  8:33 ` Sughosh Ganu [this message]
2012-03-15  3:47   ` Simon Glass
2012-03-15  5:13     ` Heiko Schocher
2012-03-15  5:23       ` Simon Glass
2012-03-15  5:29         ` Heiko Schocher
2012-03-15  7:37         ` Christian Riesch
2012-03-15 16:23           ` Simon Glass
2012-03-16 18:20     ` Sughosh Ganu
2012-05-07 12:28 ` Stefan Roese
2012-05-07 22:51   ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120310083345.GA6861@Hardy \
    --to=urwithsughosh@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox